-
Notifications
You must be signed in to change notification settings - Fork 27
Disallow package docs except for latest #496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
samccann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but we could go all the way up to Ansible 10 (and soon Ansible 12).
Prevent agents from crawling and indexing eol versions of the package docs. This improves SEO by reducing the number of pages that can't be indexed. This change also helps funnel users to the latest docs version.
f1c252c to
50aee97
Compare
samccann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@samccann I've been rethinking disallowing the supported package versions. Consider the RTD docs about version states: https://docs.readthedocs.com/platform/latest/versions.html#version-states The default behaviour is to disallow hidden versions in We need to explicitly declare whatever rules are needed because I don't think subprojects get their own |
|
Here are the versions on the flyout widget:
This corresponds to the branches in https://github.com/ansible/ansible-documentation/blob/2aada29638a9ad769e3a8c7d66868a4408e0d9b7/.github/workflows/pip-compile-dev.yml @samccann What do you think about hiding the |
|
Maybe if we hide
|
|
Not to make this more complex, though I agree we should think about I've marked this PR as draft till Don had decided what he wants to do here. |

The purpose of this change is to disallow crawlers from all Ansible package docs versions except for the latest version, currently 13. We want to do this so that search results return for latest versions.