Skip to content

Conversation

@beeankha
Copy link
Contributor

@beeankha beeankha commented Oct 21, 2025

SUMMARY

Resolves #1027

Copy link
Contributor

@yurnov yurnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@softwarefactory-project-zuul
Copy link

@yurnov
Copy link
Contributor

yurnov commented Oct 21, 2025

Ideally, it should be tested and merged with coordination with github_actions/pull/180 as we have stated that CI has tests against 2.21, but does not have tests of 2.20. And also, after bringing Python 3.14 (that is supported starting from 2.20) ignore files to be updated.

In any case, this PR can be merged, everything above can be addressed later

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/33320790e8b04d86b16f64c83266e685

✔️ ansible-galaxy-importer SUCCESS in 3m 20s
✔️ build-ansible-collection SUCCESS in 5m 49s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1c16a2d into ansible-collections:main Oct 23, 2025
47 checks passed
@patchback
Copy link

patchback bot commented Oct 23, 2025

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/1c16a2d2b59d62c79b2bbf56b665038e93bf0aad/pr-1032

Backported as #1035

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 23, 2025
SUMMARY

Resolves #1027

Reviewed-by: Yuriy Novostavskiy <[email protected]>
Reviewed-by: GomathiselviS <[email protected]>
(cherry picked from commit 1c16a2d)
@patchback
Copy link

patchback bot commented Oct 23, 2025

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/1c16a2d2b59d62c79b2bbf56b665038e93bf0aad/pr-1032

Backported as #1036

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 23, 2025
SUMMARY

Resolves #1027

Reviewed-by: Yuriy Novostavskiy <[email protected]>
Reviewed-by: GomathiselviS <[email protected]>
(cherry picked from commit 1c16a2d)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Oct 23, 2025
This is a backport of PR #1032 as merged into main (1c16a2d).
SUMMARY

Resolves #1027

Reviewed-by: Bianca Henderson <[email protected]>
beeankha added a commit that referenced this pull request Oct 24, 2025
SUMMARY

Resolves #1027

Reviewed-by: Yuriy Novostavskiy <[email protected]>
Reviewed-by: GomathiselviS <[email protected]>
(cherry picked from commit 1c16a2d)

Co-authored-by: Bianca Henderson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sanity is failed on ansible 2.21

3 participants