-
Notifications
You must be signed in to change notification settings - Fork 45
[New module] zos_started_task #2377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging-v1.16.0-beta.1
Are you sure you want to change the base?
Conversation
|
Start command response when started task gets started successfully: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is impressive! Please should check with Fernando about adding a changelog fragment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request few minor changes
plugins/modules/zos_started_task.py
Outdated
| type: str | ||
| aliases: | ||
| - identifier | ||
| get_system_logs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change this option's name to system_logs, we are trying to avoid the verb options for the new 2.0 version so is better to have the same guidelines applied here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
plugins/modules/zos_started_task.py
Outdated
| - When I(state) is started, this is the name which should be assigned to a started task | ||
| while starting it. If I(job_name) is not specified, then I(member_name) is used as job's name. | ||
| - When I(state) is C(displayed), C(modified), C(cancelled), C(stopped), or C(forced), I(job_name) is the | ||
| started task name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add bit more detail in here
| started task name. | |
| started task name used to query the system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
plugins/modules/zos_started_task.py
Outdated
| type: bool | ||
| cmd: | ||
| description: | ||
| - Command executed via opercmd. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Command executed via opercmd. | |
| - Command executed via opercmd to achieve the desired state. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
plugins/modules/zos_started_task.py
Outdated
| sample: 00000.00.00.003 | ||
| elapsed_time: | ||
| description: | ||
| - The processor time used by the address space, including the initiator. This time does not include SRB time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description is the same as cpu_time is that intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
plugins/modules/zos_started_task.py
Outdated
| verbose_output=task_output_logs | ||
| ) | ||
| if msg: | ||
| result['msg'] = msg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PLease always return msg even is if empty, we are trying to return more consistent values in the collection overall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all comments, making changes after feedback sessions where we went back and forth multiple times, even reverting previously agreed behaviors.
Appreciate your effort and attention to detail during the whole development process.
SUMMARY
New module zos_started_task which support start, display, modify, cancel, stop and force operations.
ISSUE TYPE
New Module Pull Request
COMPONENT NAME
zos_started_task
ADDITIONAL INFORMATION