Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] vmware_vmkernel: Requirements in argument_spec #2295

Closed
wants to merge 1 commit into from
Closed

[WIP] vmware_vmkernel: Requirements in argument_spec #2295

wants to merge 1 commit into from

Conversation

mariolenz
Copy link
Collaborator

SUMMARY

I've had look at implementing #1740 and found out that the module handles some option dependencies in the code. I think it would be better to make those dependencies explicit in the argument_spec.

Additionally, I've tried to improve the documentation a bit.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_vmkernel

ADDITIONAL INFORMATION

Dependencies between module options

@mariolenz mariolenz force-pushed the 20250126-vmware_vmkernel branch from cfce3d9 to 036aa08 Compare January 26, 2025 14:27
@mariolenz mariolenz added documentation Improvements or additions to documentation feature This issue/PR relates to a feature request labels Jan 26, 2025
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/54652d42d4c34ec894eceec20d259956

✔️ ansible-tox-linters SUCCESS in 4m 42s
✔️ build-ansible-collection SUCCESS in 7m 26s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 16m 32s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 14m 45s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 FAILURE in 44m 20s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 16s

@mariolenz mariolenz changed the title vmware_vmkernel: Requirements in argument_spec [WIP] vmware_vmkernel: Requirements in argument_spec Jan 26, 2025
@mariolenz mariolenz added the WIP Work in progress label Jan 26, 2025
@mariolenz mariolenz mentioned this pull request Jan 27, 2025
Merged
@mariolenz
Copy link
Collaborator Author

I think this change is wrong. It doesn't make sense to require that people specify network.ip_address and network.subnet_mask if they simply want to remove a vmkernel interface.

Additionally, it would be a breaking change.

@mariolenz mariolenz closed this Jan 27, 2025
@mariolenz mariolenz deleted the 20250126-vmware_vmkernel branch January 27, 2025 16:54
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 2, 2025
@mariolenz
vmware_vmkernel: Improve documentation (#2296)
b9604e3 
SUMMARY
Improving the documentation a bit:

The options dealing with IP stuff is about IPv4.
ip_address and subnet_mask aren't required if state is absent.

ISSUE TYPE

Docs Pull Request

COMPONENT NAME
vmware_vmkernel
ADDITIONAL INFORMATION
#1740
#2295

Reviewed-by: Alexander Nikitin <ihumster@ihumster.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation feature This issue/PR relates to a feature request WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mariolenz