vmware_guest speedup module

[GuideGlyph]

SUMMARY

Speedup network search while creating VM using vmware_guest.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

vmware_guest.py

ADDITIONAL INFORMATION

vmware_guest network search is slow. It use find_obj() from vmware.py that loop through all objects trying to find correct. I have a lag for 5 mins trying. PyVmomi.network_exists_by_name works much faster.

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4c09106c777d49a6b5af0706d5ea35ce

✔️ ansible-tox-linters SUCCESS in 4m 48s
✔️ build-ansible-collection SUCCESS in 8m 09s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 22m 04s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 19m 18s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 1h 10m 01s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 44m 54s
✔️ ansible-galaxy-importer SUCCESS in 5m 53s

[GuideGlyph]

also curios why Clone task

                    task = vm_obj.Clone(folder=destfolder, name=self.params['name'], spec=clonespec)

dont have self.wait_for_task(task) line like CreateVM_Task or ReconfigVM_Task.
After debugging customize_advanced_settings function (not successfully sadly) I get incorrect facts = self.gather_facts(vm_obj) couple of times because it didnt have time enough to get it correct (i guess)

[GuideGlyph]

TODO: also add find_network_by_name function to

                if nic.device.deviceInfo.summary != network_name:
                    if 'DVSwitch' not in nic.device.deviceInfo.summary:
                        nic.device.deviceInfo.summary = network_name
                        nic_change_detected = True
                    else:

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/16d554799b7140aba8e4a5ba2c1d8ce9

✔️ ansible-tox-linters SUCCESS in 4m 38s
✔️ build-ansible-collection SUCCESS in 7m 51s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 16m 34s
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable218 FAILURE in 20m 17s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 3m 13s

[GuideGlyph]

Recheck

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/adc0a20da6cd4da188caa116614b3220

✔️ ansible-tox-linters SUCCESS in 4m 26s
✔️ build-ansible-collection SUCCESS in 7m 43s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 16m 35s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 18m 47s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 1h 18m 40s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 46m 09s
✔️ ansible-galaxy-importer SUCCESS in 4m 46s

[mariolenz]

I'm sorry, I didn't find much time to work on this collection during the last weeks. I hope I'm able to review this PR soon.

[mariolenz]

@GuideGlyph Please a changelog fragment. Maybe something like

changelogs/fragments/2278-vmware_guest.yml:

minor_changes:
  - vmware_guest - Speedup network search
    (https://github.com/ansible-collections/community.vmware/pull/2278).

[GuideGlyph]

@mariolenz ready

[mariolenz]

Thanks @GuideGlyph!

I'm not 100% sure that I understand your changes. But if this speeds up things for you and the CI is happy 🤷

FYI I'm planing to do a new release within the next few days, possibly next weekend.

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/dec53e72b73b437ca53acfbd67d4b526

✔️ ansible-tox-linters SUCCESS in 4m 46s
✔️ build-ansible-collection SUCCESS in 7m 51s
✔️ ansible-test-cloud-integration-vcenter7_only-stable218 SUCCESS in 20m 48s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable218 SUCCESS in 13m 40s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_1_of_2 SUCCESS in 1h 05m 56s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable218_2_of_2 SUCCESS in 47m 40s
✔️ ansible-galaxy-importer SUCCESS in 4m 28s

[GuideGlyph]

Thanks @GuideGlyph!

I'm not 100% sure that I understand your changes. But if this speeds up things for you and the CI is happy 🤷

FYI I'm planing to do a new release within the next few days, possibly next weekend.

Thanks for review!
If someone is interested why it works some info here
#2277 (comment)

[mariolenz]

Thanks for the additional info @GuideGlyph! I'd have merged this already yesterday, but somehow our CI/CD didn't want me to. I'll give it another try now :-)

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/587b486e8bd94d08be9c5706885e1e31

✔️ ansible-tox-linters SUCCESS in 5m 23s
✔️ build-ansible-collection SUCCESS in 6m 01s
✔️ ansible-galaxy-importer SUCCESS in 4m 24s