-
Notifications
You must be signed in to change notification settings - Fork 5
Add server_info action plugin
#11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
server_info action pluginserver_info action plugin
5439866 to
12a2b93
Compare
f74a279 to
f2c19e7
Compare
|
Build succeeded. ✔️ build-ansible-collection SUCCESS in 5m 40s |
|
Build failed. ✔️ build-ansible-collection SUCCESS in 5m 46s |
|
Build failed. ✔️ build-ansible-collection SUCCESS in 5m 46s |
|
Build failed. ✔️ build-ansible-collection SUCCESS in 5m 45s |
f8b8587 to
7b6c8b6
Compare
7b6c8b6 to
80f0ce1
Compare
|
Build failed. ✔️ build-ansible-collection SUCCESS in 5m 37s |
|
Build failed. ✔️ build-ansible-collection SUCCESS in 5m 43s |
server_info action pluginserver_info action plugin
.github/workflows/tests.yml
Outdated
| "python": "3.12" | ||
| } | ||
| ] | ||
| integration: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
integration will be ran using zuul, this workflow should be removed
abikouo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The integration test is missing the alias file with the cloud/aws sentence to generate aws credentials for tests
| return result | ||
|
|
||
| except Exception as e: | ||
| raise AnsibleActionFail("Failed to retrieve server info: %s" % str(e)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in this case we should treat it like a module failure. So rather than raising an exception, we should do something like:
result["failed"] = True
result["msg"] = "some useful error message..."
result["exception"] = "".join(traceback.format_exception(None, e, e.__traceback__))| "github-server": { | ||
| "type": "stdio", | ||
| "command": "npx", | ||
| "args": ["-y", "@modelcontextprotocol/server-github"], | ||
| "description": "GitHub MCP Server - Access GitHub repositories, issues, and pull requests" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This specifically needs to be type: http and use the https://api.githubcopilot.com/mcp/ url.
|
Build failed. ✔️ build-ansible-collection SUCCESS in 5m 46s |
|
Build failed. ✔️ build-ansible-collection SUCCESS in 5m 47s |
SUMMARY
Resolves ACA-4357
ISSUE TYPE
COMPONENT NAME
server_info