Skip to content

fix(desktop): open external links in default browser #8520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leonardomso wants to merge 1 commit into from
Closed

fix(desktop): open external links in default browser #8520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions packages/desktop/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,23 @@ root?.addEventListener("mousewheel", (e) => {
e.stopPropagation()
})

// Intercept all link clicks and open external links in the default browser
root?.addEventListener("click", (e) => {
const target = e.target as HTMLElement
const anchor = target.closest("a")
if (!anchor) return

const href = anchor.getAttribute("href")
if (!href) return

// Only intercept external links (http/https)
if (href.startsWith("http://") || href.startsWith("https://")) {
e.preventDefault()
e.stopPropagation()
void shellOpen(href).catch(() => undefined)
}
})

render(() => {
const [serverPassword, setServerPassword] = createSignal<string | null>(null)
const platform = createPlatform(() => serverPassword())
Expand Down