fix(tui): prevent UI freezes from clipboard operations and event loop #7395
+101
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace Bun.$ with node:child_process in clipboard.ts to avoid GC crashes - Add debouncing to clipboard copy operations (100ms) - Add yield point in SDK event loop to prevent render thread starvation Addresses Bun shell GC bug: oven-sh/bun#23177
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bun.$withnode:child_processin clipboard.ts to avoid GC crashes caused by Bun shell interpreter bugProblem
TUI would intermittently freeze, especially when clipboard operations were triggered. Root cause traced to Bun shell interpreter GC bug (oven-sh/bun#23177) where the shell interpreter is freed while still in use.
Solution
Bun.$usage with Node.jschild_process(spawn, execSync) which doesn't have this issuedebouncedCopy()function wrapping all 4 clipboard copy calls with 100ms debounceawait new Promise((r) => setTimeout(r, 0))after flush to yield to render threadTesting
Manual testing confirms UI no longer freezes during clipboard operations.
Related