Add Array.isArray check before .join() #7394
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both changes are applied. The fix adds defensive type checking in the
formatfunction to handle cases where the answer might be a string instead of an array. This can happen when loading older sessions or if data gets stored in an unexpected format.Summary of the fix:
The bug occurred because
props.metadata.answers?.[i()]could sometimes be a string instead of an array (string[]), causinganswer.join(", ")to fail since strings don't have ajoinmethod.The fix adds a type check before calling
.join():answeris falsy or empty, return the fallback textansweris not an array, convert it to a string withString(answer).join(", ")as beforeThis makes the code resilient to data type variations that might occur when loading historical sessions.
Closes #7392
opencode session | github run