feat(desktop): add hardware acceleration toggle for Windows #10311
+2,245
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add file tree explorer with expand/collapse folders - Add Monaco editor with syntax highlighting for 25+ languages - Add theme integration (syncs with OpenCode themes including preview) - Add Ctrl+S save, file polling for external changes - Add Tauri backend commands: read_directory, read_file, write_file, get_project_root - Add editor toggle button in session header - Add editor poll interval setting - Add i18n translations for all 14 languages
- Wrap ExplorerPanel with Show when={platform.readDirectory}
- Wrap EditorPanel with Show when={platform.readFile}
- Wrap editor toggle button with Show when={platform.readFile}
- Add openFile(path) method to editor context
- Review panel now shows on the right side on web (not inline above chat) - Header layout icons now correctly show 2-panel layout on web - File Editor settings section hidden on web (no file system support) The issue was that editorCtx.panelVisible() defaults to true, but the editor panel can't render on web since platform.readFile is undefined. Added platform.readFile checks to conditions so the UI correctly falls back to non-editor mode on web.
- Active tab always prompts user when file changes on disk (never auto-reload) - Background tabs auto-reload by default (for AI-edited files) - Added setting: Auto-reload background files to control behavior - When setting is off, user is prompted when switching to affected tabs
- Add 'Disable hardware acceleration' setting in Settings > General > Advanced - Only shown on Windows where WebView2 is used - Passes --disable-gpu flags to WebView2 when enabled - Requires app restart to take effect - May fix crashes and conflicts with other GPU-using apps like Chrome Related issues: anomalyco#10248, anomalyco#9385, anomalyco#9151, anomalyco#7046
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
|
Memory leaks have nothing to do with this windowscli leak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a setting to disable hardware acceleration on Windows, which may help fix crashes and conflicts with other GPU-using apps (like Chrome video playback issues).
Problem
Solution
--disable-gpu-compositingflag to WebView2 at startupChanges
packages/desktop/src-tauri/src/lib.rs- Read setting at startup, pass browser argspackages/desktop/src/index.tsx- Platform methods for get/setpackages/app/src/context/platform.tsx- Type definitionspackages/app/src/components/settings-general.tsx- UI togglepackages/app/src/i18n/en.ts- TranslationsTesting