Skip to content

refactor: migrate business logic from DeckPicker to DeckPickerViewModel #19267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2025
Merged

refactor: migrate business logic from DeckPicker to DeckPickerViewModel #19267

merged 1 commit into from
Nov 5, 2025
+138 −114

Conversation

@sanjaysargam
Copy link
Member

@sanjaysargam sanjaysargam commented Sep 24, 2025

Purpose / Description

Migrate business logic methods from DeckPicker Activity to DeckPickerViewModel.

Fixes

How Has This Been Tested?

Physical Device (Realme 9 Pro 5G)

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@sanjaysargam
refactor: migrate business logic from DeckPicker to DeckPickerViewModel
7d4e26f 
  Move business logic methods to improve MVVM architecture:
  - Move getPreviousVersion() with version upgrade detection logic
  - Move fetchSyncIconState() with sync status management
  - Move updateMenuState() with menu state calculation
  - Move OptionsMenuState and SyncIconState data classes
  - Move UPGRADE_VERSION_KEY constant to ViewModel companion object
david-allison
david-allison approved these changes Nov 4, 2025
View reviewed changes
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Nov 4, 2025
@BrayanDSO BrayanDSO added Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Nov 5, 2025
@BrayanDSO BrayanDSO added this pull request to the merge queue Nov 5, 2025
Merged via the queue into ankidroid:main with commit cb26cd5 Nov 5, 2025
10 checks passed
@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Nov 5, 2025
@github-actions github-actions bot added this to the 2.23 release milestone Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david-allison david-allison david-allison approved these changes

@BrayanDSO BrayanDSO BrayanDSO approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.23 release

Development

Successfully merging this pull request may close these issues.

3 participants

@sanjaysargam @david-allison @BrayanDSO