-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: implement New JavaScript API in the study screen and previewers #19152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BrayanDSO
wants to merge
9
commits into
ankidroid:main
Choose a base branch
from
BrayanDSO:ts-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,497
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Maintainers: This PR contains Strings changes
|
46de383 to
375c523
Compare
when getting an optional number (Long, Double, Int) of a JSONObject, the default methods always return some number as fallback, such as 0, instead of returning null so this adds nullable methods like getStringOrNull
Adds a set of Enums to represent the API endpoints js-api-endpoints is a file generated by the API `export-endpoints.ts` script.
mathjax and jquery come from the backend now
works on the new study screen and the previewers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Implements the New JavaScript API (which needs to be reviewed as well) in the new study screen and the previewers.
Approach
In the commits
How Has This Been Tested?
Emulator 34 with the api_showcase sample template:
study.screen.webm
previewer.webm
Learning (optional, can help others)
Using CompletableDeferred is a nice hack to send requests from the viewModel to the view
Checklist
Please, go through these checks before submitting the PR.