Skip to content

chore: update action to ensure we get the reference before running "prettier" #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2021
Merged

chore: update action to ensure we get the reference before running "prettier" #305

merged 3 commits into from
Oct 18, 2021

Conversation

@ftonato
Copy link
Contributor

@ftonato ftonato commented Oct 17, 2021 •
edited
Loading

Description

In order to fix the current problem we have with the action that is executed for "prettier", this PR forces that within the checkout action we always have the last reference (from current branch or pull-request).

Type of Change:

  • Chore (Process update)

Issues

Fixes: #310

References

@isabelcosta
Copy link
Member

isabelcosta commented Oct 17, 2021

cc @brittanyjoiner15 this PR looks relevant to your previous work :)

@isabelcosta
Copy link
Member

isabelcosta commented Oct 17, 2021

@ftonato do you know why the check might be failing?

@isabelcosta
Copy link
Member

isabelcosta commented Oct 17, 2021

@ftonato could you also create a ticket and link this PR to that issue. In this way, we have the issue documented and if for any reason you don't finish this, someone else can pick this up :)

@ftonato
Copy link
Contributor Author

ftonato commented Oct 17, 2021

It's failing because "prettier" is trying to find any file regardless of file types (like .js or .json). I'll update the PR by adding the types that should be considered by the tool.

@isabelcosta isabelcosta requested a review from nandini45 October 17, 2021 21:32
@ftonato ftonato force-pushed the chore/update-prettier branch from 8465aa9 to 8bc7e42 Compare October 17, 2021 21:44
@ftonato ftonato force-pushed the chore/update-prettier branch from 8bc7e42 to 3db5000 Compare October 17, 2021 22:06
@ftonato ftonato mentioned this pull request Oct 17, 2021
Closed
isabelcosta
isabelcosta approved these changes Oct 17, 2021
View reviewed changes
Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for reporting and fixing this issue!

@isabelcosta isabelcosta added the Status: Needs Review PR needs an additional review or a maintainer's review. label Oct 17, 2021
@isabelcosta isabelcosta mentioned this pull request Oct 17, 2021
Merged
3 tasks
@anishfyi
Copy link
Contributor

anishfyi commented Oct 17, 2021 •
edited
Loading

@isabelcosta @ftonato
I Had an MR Pending and PR Checks Were Failing For Me as well #302 .
So I Took Your Prettier Changes of deploy.yml issue #305 .

My PR: #302

isabelcosta
isabelcosta reviewed Oct 17, 2021
View reviewed changes
@isabelcosta isabelcosta added Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels Oct 18, 2021
@isabelcosta
Copy link
Member

isabelcosta commented Oct 18, 2021

Thank you @daxoron for reviewing 🙏🏾

@isabelcosta isabelcosta merged commit 8db566a into anitab-org:develop Oct 18, 2021
@brittanyjoiner15
Copy link
Contributor

brittanyjoiner15 commented Oct 18, 2021

thanks @ftonato for taking care of this!

@isabelcosta isabelcosta mentioned this pull request Oct 18, 2021
Merged
3 tasks
ftonato added a commit to ftonato/anitab-org.github.io that referenced this pull request Oct 19, 2021
@ftonato
chore: update action to ensure we get the reference before running "p…
efab163 
…rettier" (anitab-org#305)

* chore: update action to ensure we get the reference before running "prettier"
* chore: update the "prettier" process to take into account only certain file types
* chore: add new type of files to be considered by prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isabelcosta isabelcosta isabelcosta approved these changes

@codesankalp codesankalp Awaiting requested review from codesankalp

@vj-codes vj-codes Awaiting requested review from vj-codes

@nandini45 nandini45 Awaiting requested review from nandini45

@Rahulm2310 Rahulm2310 Awaiting requested review from Rahulm2310

+1 more reviewer

@anishfyi anishfyi anishfyi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Status: Ready to Merge Work has been tested and needs a final review and merge from a repo maintainer.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GitHub Actions for Prettier process is failing / not respecting some rules that should

4 participants

@ftonato @isabelcosta @anishfyi @brittanyjoiner15