Skip to content

Conversation

@rutvi18
Copy link

@rutvi18 rutvi18 commented Feb 7, 2021

Description

Changed the duplicated image for both the images.

Fixes the issue #214 .

Type of Change:

  • Code
  • Quality Assurance
  • User Interface
  • Outreach
  • Documentation

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

image
image

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings

@annabauza
Copy link
Contributor

@rutvi18 did you followed any design? @nandini45 do you know which image should be displayed here? I thought we use all galaxy on landing page, no?

@annabauza annabauza added Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner. labels Feb 7, 2021
@rutvi18
Copy link
Author

rutvi18 commented Feb 7, 2021

@annabauza not followed a design as such and in landing folder only two images were there thats why I used from different folder

@rutvi18
Copy link
Author

rutvi18 commented Feb 9, 2021

@annabauza can u please update for the changes required?

@nandini45
Copy link
Member

@rutvi18 can u tell me the page issue your are working on

@rutvi18
Copy link
Author

rutvi18 commented Feb 14, 2021

@nandini45 I am working on the Home page (home.js)

@nandini45
Copy link
Member

nandini45 commented Feb 16, 2021

@rutvi18 ur issue is valid one but the issue here is we didn't planned any intial images to be placed there
so for now give me some time
i will look into some illustrations if approved i will come back to you. sounds good??
and the image you placed as a replacement is already being used at other places

@rutvi18
Copy link
Author

rutvi18 commented Feb 17, 2021

@nandini45 ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: Coding Changes to code base or refactored code that doesn't fix a bug. Status: On Hold Issue or PR needs more info, a discussion, a review or approval from a Maintainer/Code Owner.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants