Skip to content

Fix/mcp server bugs #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tazovsky wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/mcp server bugs #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
206e483
fix: MCP server protocol compliance (NDJSON, dynamic IDs, text type)
Tazovsky Feb 12, 2026
5b9b142
fix: MCP server reads PID/log from project dir instead of plugin dir
Tazovsky Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .claude-plugin/plugin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"workflow",
"ci-cd"
],
"hooks": "./hooks.json",
"hooks": "./hooks/hooks.json",
"mcpServers": "./.mcp.json"
}

77 changes: 49 additions & 28 deletions mcp-server/nights-watch-server.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,11 @@
PLUGIN_ROOT="${NIGHTS_WATCH_ROOT:-$(cd "$(dirname "$0")/.." && pwd)}"
MANAGER_SCRIPT="$PLUGIN_ROOT/claude-nights-watch-manager.sh"
DAEMON_SCRIPT="$PLUGIN_ROOT/claude-nights-watch-daemon.sh"
PID_FILE="$PLUGIN_ROOT/logs/claude-nights-watch-daemon.pid"
LOG_FILE="$PLUGIN_ROOT/logs/claude-nights-watch-daemon.log"
# PID and log files are written to the project directory by the daemon/manager,
# not the plugin directory. Use CLAUDE_NIGHTS_WATCH_DIR (or CWD) to match.
TASK_DIR="${CLAUDE_NIGHTS_WATCH_DIR:-$(pwd)}"
PID_FILE="$TASK_DIR/logs/claude-nights-watch-daemon.pid"
LOG_FILE="$TASK_DIR/logs/claude-nights-watch-daemon.log"

# MCP Protocol Implementation
# This is a simplified MCP server that responds to tool calls
Expand Down Expand Up @@ -154,7 +157,7 @@ get_daemon_status() {
local status="stopped"
local pid=""
local details=""

if [ -f "$PID_FILE" ]; then
pid=$(cat "$PID_FILE")
if kill -0 "$pid" 2>/dev/null; then
Expand All @@ -166,7 +169,7 @@ get_daemon_status() {
else
details="Daemon is not running (no PID file)"
fi

cat << EOF
{
"jsonrpc": "2.0",
Expand All @@ -175,7 +178,7 @@ get_daemon_status() {
"content": [
{
"type": "text",
"text": $(jq -n --arg s "$status" --arg p "$pid" --arg d "$details" '{status: $s, pid: $p, details: $d}' | jq -c .)
"text": $(jq -n --arg s "$status" --arg p "$pid" --arg d "$details" '({status: $s, pid: $p, details: $d} | tojson)')
}
]
}
Expand All @@ -186,14 +189,14 @@ EOF
start_daemon() {
local start_time="$1"
local args=""

if [ -n "$start_time" ]; then
args="--at \"$start_time\""
fi

local output=$(eval "$MANAGER_SCRIPT start $args" 2>&1)
local exit_code=$?

cat << EOF
{
"jsonrpc": "2.0",
Expand All @@ -214,7 +217,7 @@ EOF
stop_daemon() {
local output=$("$MANAGER_SCRIPT" stop 2>&1)
local exit_code=$?

cat << EOF
{
"jsonrpc": "2.0",
Expand All @@ -234,7 +237,7 @@ EOF

get_logs() {
local lines="${1:-50}"

if [ -f "$LOG_FILE" ]; then
local logs=$(tail -n "$lines" "$LOG_FILE")
cat << EOF
Expand Down Expand Up @@ -271,7 +274,7 @@ EOF

read_task() {
local path="${1:-./task.md}"

if [ -f "$path" ]; then
local content=$(cat "$path")
cat << EOF
Expand Down Expand Up @@ -309,7 +312,7 @@ EOF

read_rules() {
local path="${1:-./rules.md}"

if [ -f "$path" ]; then
local content=$(cat "$path")
cat << EOF
Expand Down Expand Up @@ -348,9 +351,9 @@ EOF
write_task() {
local content="$1"
local path="${2:-./task.md}"

echo "$content" > "$path"

cat << EOF
{
"jsonrpc": "2.0",
Expand All @@ -370,9 +373,9 @@ EOF
write_rules() {
local content="$1"
local path="${2:-./rules.md}"

echo "$content" > "$path"

cat << EOF
{
"jsonrpc": "2.0",
Expand All @@ -389,55 +392,73 @@ write_rules() {
EOF
}

# Helper: send response as compact single-line JSON with correct request ID
# MCP stdio transport requires NDJSON (one JSON object per line).
# JSON-RPC requires the response id to match the request id.
send_response() {
local id="$1"
if [ "$id" != "null" ] && [ -n "$id" ]; then
jq -c --argjson id "$id" '.id = $id'
else
jq -c .
fi
}

# Main MCP server loop
# Read JSON-RPC requests from stdin and respond on stdout
while IFS= read -r line; do
# Skip empty lines
[ -z "$line" ] && continue

method=$(echo "$line" | jq -r '.method // empty')

id=$(echo "$line" | jq '.id // null')

case "$method" in
"initialize")
handle_initialize
handle_initialize | send_response "$id"
;;
"notifications/initialized")
# Notification — no response needed
;;
"tools/list")
handle_list_tools
handle_list_tools | send_response "$id"
;;
"tools/call")
tool_name=$(echo "$line" | jq -r '.params.name')
case "$tool_name" in
"get_daemon_status")
get_daemon_status
get_daemon_status | send_response "$id"
;;
"start_daemon")
start_time=$(echo "$line" | jq -r '.params.arguments.start_time // empty')
start_daemon "$start_time"
start_daemon "$start_time" | send_response "$id"
;;
"stop_daemon")
stop_daemon
stop_daemon | send_response "$id"
;;
"get_logs")
lines=$(echo "$line" | jq -r '.params.arguments.lines // 50')
get_logs "$lines"
get_logs "$lines" | send_response "$id"
;;
"read_task")
path=$(echo "$line" | jq -r '.params.arguments.path // "./task.md"')
read_task "$path"
read_task "$path" | send_response "$id"
;;
"read_rules")
path=$(echo "$line" | jq -r '.params.arguments.path // "./rules.md"')
read_rules "$path"
read_rules "$path" | send_response "$id"
;;
"write_task")
content=$(echo "$line" | jq -r '.params.arguments.content')
path=$(echo "$line" | jq -r '.params.arguments.path // "./task.md"')
write_task "$content" "$path"
write_task "$content" "$path" | send_response "$id"
;;
"write_rules")
content=$(echo "$line" | jq -r '.params.arguments.content')
path=$(echo "$line" | jq -r '.params.arguments.path // "./rules.md"')
write_rules "$content" "$path"
write_rules "$content" "$path" | send_response "$id"
;;
esac
;;
esac
done