Redesign nextjs - #5
Merged
Merged
Conversation
anhhchu
commented
Jun 8, 2026
anhhchu
commented
Owner
- Three independent improvements on top of the live site. Testimonials are now an expandable carousel (new src/components/ui/retro-testimonial.tsx) with a click-to-expand modal, adapted to the site's editorial palette and Fraunces, using monogram initials instead of headshots (no fabricated faces for real recommenders), inline SVG icons (no lucide-react), and the existing motion/react.
- The Skills section is reordered
- CI sets FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true to clear the action-hosting-deploy@v0 Node 20 deprecation warning. Verified with tsc, eslint, npm run build (static export), and in-browser.
FirebaseExtended/action-hosting-deploy@v0 still declares node20 (no node24 release tag exists yet), triggering the Node 20 deprecation warning. Set FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true at the workflow level to run all JS actions on node24; it becomes a no-op once node24 is the runner default. Co-authored-by: Isaac
Reorder the homepage/about skills list (Databricks 100% first) and add Data Warehouse · Semantic Modelling and Machine Learning. Bump the bar height from 1px to a clean 2px with rounded ends so every bar renders uniformly — 1px hairlines straddled the device-pixel grid and looked inconsistent (some rows fuzzier/thicker than others). Co-authored-by: Isaac
Add a carousel of testimonial cards with a click-to-expand modal (src/components/ui/retro-testimonial.tsx) and wire the Testimonials section to it. Adapted to the site palette and Fraunces, uses monogram initials instead of headshots (no fabricated faces for real recommenders), inline SVG icons instead of lucide-react, and motion/react. Co-authored-by: Isaac
|
Visit the preview URL for this PR (updated for commit 9aaa90b): https://anhcodesdev--pr5-redesign-nextjs-ymrzwkzx.web.app (expires Mon, 15 Jun 2026 20:13:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d83c59464d2a1eea2884e6fb6ca7e2492a8d5f73 |
❌ Deploy Preview for merry-crepe-8ae23c failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.