Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autocomplete fails when input or output is prefixed with $ #2139

Closed
1 of 2 tasks
thepuzzlemaster opened this issue Feb 3, 2025 · 3 comments
Closed
1 of 2 tasks

autocomplete fails when input or output is prefixed with $ #2139

thepuzzlemaster opened this issue Feb 3, 2025 · 3 comments
Labels
bug needs clarification needs repro

Comments

@thepuzzlemaster
Copy link

🐞 bug report

Is this a regression?

I am not sure. I haven't seen this issue before, but I also just started using a naming convention which causes it.

Description

In all of my angular components, autocomplete fails when the name of the attribute begins with a dollar sign. I recently started converting my codebase to use signals, and use a $prefix to denote that the entity is a signal. Whenever typing the name of the variable into my template (whether in a separate html file, or inlined in a component template string), pressing tab or enter to trigger autocomplete removes any partially typed value and leaves me with []="", or ()="". Removing the $ from the name of the variable makes the issue go away.

Bug Type

What does this bug affect

  • Angular Language Service VSCode extension (I think)
  • Angular Language Service server

Reproduction

Steps to reproduce the behavior:

  1. create a simple component:

@Component({
  selector: "app-my-component",
  template: "<div></div>,
})
export class MyComponent {
  public $inputValue = input<string>("");
}
  1. Use that component in a different template and attempt to auto-complete the $inputValue input signal.
  2. <app-my-component [$inpu]/> -> press tab to select $inputValue from intellisense.
  3. See `<app-my-component []="" />

Expected behavior

I expect the input name to complete and be left with:
<app-my-component [$inputValue]="" /> with the cursor between the quotes

Logs

The full log file was 66,000 lines long. But this is the part of the log file that got added when I tried to add a handler with a $ prefix, which got cleared, and an input binding without a dollar sign prefix that got auto-completed successfully - in that order.


Perf 1561 [21:58:10.644] LanguageService#LSComputeApplicableRefactorings: {"events":{},"phases":{"Unaccounted":6},"memory":{}}
Perf 1562 [21:58:10.844] LanguageService#OutliningSpans: {"events":{},"phases":{"Unaccounted":12,"OutliningSpans":187},"memory":{}}
Perf 1563 [21:58:10.896] LanguageService#LSComputeApplicableRefactorings: {"events":{},"phases":{"Unaccounted":6},"memory":{}}
Perf 1564 [21:58:18.47] LanguageService#LSComputeApplicableRefactorings: {"events":{},"phases":{"Unaccounted":7},"memory":{}}
Perf 1565 [21:58:18.345] LanguageService#OutliningSpans: {"events":{},"phases":{"Unaccounted":6,"OutliningSpans":68},"memory":{}}
Perf 1566 [21:58:18.572] LanguageService#LSComputeApplicableRefactorings: {"events":{},"phases":{"Unaccounted":6},"memory":{}}
Perf 1567 [21:58:21.837] LanguageService#LSComputeApplicableRefactorings: {"events":{},"phases":{"Unaccounted":11},"memory":{}}
Perf 1568 [21:58:22.627] LanguageService#LSComputeApplicableRefactorings: {"events":{},"phases":{"Unaccounted":12},"memory":{}}
Perf 1569 [21:58:23.29] LanguageService#LSComputeApplicableRefactorings: {"events":{},"phases":{"Unaccounted":12},"memory":{}}
Perf 1570 [21:58:23.431] LanguageService#LSComputeApplicableRefactorings: {"events":{},"phases":{"Unaccounted":18},"memory":{}}
Info 1571 [21:58:23.741] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1572 [21:58:23.764] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 48 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 22.880208000016864ms
Info 1573 [21:58:23.764] Different program with same set of files
Info 1574 [21:58:23.807] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1575 [21:58:23.824] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 49 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 16.734540999983437ms
Info 1576 [21:58:23.824] Different program with same set of files
Perf 1577 [21:58:23.824] LanguageService#OutliningSpans: {"events":{"InputDtsFile":867,"InputTsFile":153,"AnalyzeComponent":1,"TraitAnalyze":1,"TraitReuseAnalysis":72,"SourceFileReuseAnalysis":115,"GenerateTcb":1,"UpdateTypeCheckProgram":1},"phases":{"Unaccounted":1263,"Reconciliation":470,"Analysis":13357,"Resolve":22902,"TcbUpdateProgram":17328,"OutliningSpans":4551},"memory":{"Initial":357187316,"Analysis":357969928,"Resolve":358982068,"TtcUpdateProgram":361607760}}
Perf 1578 [21:58:23.862] LanguageService#LsDiagnostics: {"events":{},"phases":{"Unaccounted":7,"TtcDiagnostics":17263,"TtcSymbol":2716,"LsDiagnostics":3010},"memory":{}}
Info 1579 [21:58:40.609] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1580 [21:58:40.629] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 50 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 19.628082999988692ms
Info 1581 [21:58:40.629] Different program with same set of files
Info 1582 [21:58:40.672] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1583 [21:58:40.689] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 51 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 16.752416000002995ms
Info 1584 [21:58:40.689] Different program with same set of files
Perf 1585 [21:58:40.693] LanguageService#LsCompletions: {"events":{"InputDtsFile":867,"InputTsFile":153,"AnalyzeComponent":1,"TraitAnalyze":1,"TraitReuseAnalysis":72,"SourceFileReuseAnalysis":115,"GenerateTcb":1,"UpdateTypeCheckProgram":1},"phases":{"Unaccounted":1358,"Reconciliation":582,"Analysis":11716,"Resolve":25135,"TcbUpdateProgram":17237,"TtcSymbol":2469,"LsCompletions":5680},"memory":{"Initial":368771780,"Analysis":365770880,"Resolve":366300024,"TtcUpdateProgram":367389348}}
Perf 1586 [21:58:40.805] LanguageService#LsCompletions: {"events":{},"phases":{"Unaccounted":8,"TtcSymbol":1,"LsCompletions":77371},"memory":{}}
Perf 1587 [21:58:40.806] LanguageService#LsSignatureHelp: {"events":{},"phases":{"Unaccounted":2,"LsSignatureHelp":68},"memory":{}}
Perf 1588 [21:58:40.832] LanguageService#OutliningSpans: {"events":{},"phases":{"Unaccounted":4,"OutliningSpans":69},"memory":{}}
Perf 1589 [21:58:40.859] LanguageService#LSComputeApplicableRefactorings: {"events":{},"phases":{"Unaccounted":5},"memory":{}}
Perf 1590 [21:58:40.923] LanguageService#LsDiagnostics: {"events":{},"phases":{"Unaccounted":7,"TtcDiagnostics":12025,"TtcSymbol":1478,"LsDiagnostics":1247},"memory":{}}
Info 1591 [21:58:41.28] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1592 [21:58:41.42] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 52 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 14.056374999985565ms
Info 1593 [21:58:41.42] Different program with same set of files
Info 1594 [21:58:41.78] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1595 [21:58:41.96] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 53 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 18.384375000023283ms
Info 1596 [21:58:41.96] Different program with same set of files
Perf 1597 [21:58:41.108] LanguageService#LsCompletions: {"events":{"InputDtsFile":867,"InputTsFile":153,"AnalyzeComponent":1,"TraitAnalyze":1,"TraitReuseAnalysis":72,"SourceFileReuseAnalysis":115,"GenerateTcb":1,"UpdateTypeCheckProgram":1},"phases":{"Unaccounted":952,"Reconciliation":413,"Analysis":7852,"Resolve":22590,"TcbUpdateProgram":18888,"TtcSymbol":2682,"LsCompletions":13132},"memory":{"Initial":371426136,"Analysis":372886540,"Resolve":375535624,"TtcUpdateProgram":377543748}}
Perf 1598 [21:58:41.234] LanguageService#OutliningSpans: {"events":{},"phases":{"Unaccounted":6,"OutliningSpans":439},"memory":{}}
Perf 1599 [21:58:41.287] LanguageService#LSComputeApplicableRefactorings: {"events":{},"phases":{"Unaccounted":10},"memory":{}}
Perf 1600 [21:58:41.341] LanguageService#LsDiagnostics: {"events":{},"phases":{"Unaccounted":6,"TtcDiagnostics":10616,"TtcSymbol":1488,"LsDiagnostics":1153},"memory":{}}
Info 1601 [21:58:43.11] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1602 [21:58:43.28] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 54 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 17.205541999981506ms
Info 1603 [21:58:43.29] Different program with same set of files
Info 1604 [21:58:43.67] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1605 [21:58:43.82] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 55 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 14.852458000008482ms
Info 1606 [21:58:43.82] Different program with same set of files
Perf 1607 [21:58:43.83] LanguageService#OutliningSpans: {"events":{"InputDtsFile":867,"InputTsFile":153,"AnalyzeComponent":1,"TraitAnalyze":1,"TraitReuseAnalysis":72,"SourceFileReuseAnalysis":115,"GenerateTcb":1,"UpdateTypeCheckProgram":1},"phases":{"Unaccounted":1460,"Reconciliation":714,"Analysis":7670,"Resolve":25503,"TcbUpdateProgram":15390,"OutliningSpans":3179},"memory":{"Initial":381288960,"Analysis":378690240,"Resolve":378882976,"TtcUpdateProgram":381419380}}
Perf 1608 [21:58:43.83] LanguageService#LSComputeApplicableRefactorings: {"events":{},"phases":{"Unaccounted":2},"memory":{}}
Perf 1609 [21:58:43.126] LanguageService#LsDiagnostics: {"events":{},"phases":{"Unaccounted":6,"TtcDiagnostics":11427,"TtcSymbol":1948,"LsDiagnostics":2575},"memory":{}}
Perf 1610 [21:58:44.196] LanguageService#LSComputeApplicableRefactorings: {"events":{},"phases":{"Unaccounted":9},"memory":{}}
Info 1611 [21:58:44.494] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1612 [21:58:44.513] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 56 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 18.106208000011975ms
Info 1613 [21:58:44.513] Different program with same set of files
Info 1614 [21:58:44.550] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1615 [21:58:44.568] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 57 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 17.792082999978447ms
Info 1616 [21:58:44.568] Different program with same set of files
Perf 1617 [21:58:44.568] LanguageService#OutliningSpans: {"events":{"InputDtsFile":867,"InputTsFile":153,"AnalyzeComponent":1,"TraitAnalyze":1,"TraitReuseAnalysis":72,"SourceFileReuseAnalysis":115,"GenerateTcb":1,"UpdateTypeCheckProgram":1},"phases":{"Unaccounted":1410,"Reconciliation":1995,"Analysis":8533,"Resolve":22043,"TcbUpdateProgram":18265,"OutliningSpans":2809},"memory":{"Initial":382311164,"Analysis":385778296,"Resolve":385998736,"TtcUpdateProgram":388678640}}
Perf 1618 [21:58:44.710] LanguageService#LsDiagnostics: {"events":{},"phases":{"Unaccounted":10,"TtcDiagnostics":110114,"TtcSymbol":2189,"LsDiagnostics":1606},"memory":{}}
Info 1619 [21:58:57.761] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1620 [21:58:57.779] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 58 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 18.37041699999827ms
Info 1621 [21:58:57.779] Different program with same set of files
Info 1622 [21:58:57.822] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1623 [21:58:57.837] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 59 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 15.267332999996142ms
Info 1624 [21:58:57.837] Different program with same set of files
Perf 1625 [21:58:57.841] LanguageService#LsCompletions: {"events":{"InputDtsFile":867,"InputTsFile":153,"AnalyzeComponent":1,"TraitAnalyze":1,"TraitReuseAnalysis":72,"SourceFileReuseAnalysis":115,"GenerateTcb":1,"UpdateTypeCheckProgram":1},"phases":{"Unaccounted":1334,"Reconciliation":561,"Analysis":13482,"Resolve":22944,"TcbUpdateProgram":15794,"TtcSymbol":2396,"LsCompletions":4684},"memory":{"Initial":363848468,"Analysis":360580172,"Resolve":360895848,"TtcUpdateProgram":364430600}}
Info 1626 [21:58:58.38] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1627 [21:58:58.55] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 60 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 16.68404200000805ms
Info 1628 [21:58:58.55] Different program with same set of files
Info 1629 [21:58:58.156] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1630 [21:58:58.175] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 61 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 19.80729200001224ms
Info 1631 [21:58:58.175] Different program with same set of files
Perf 1632 [21:58:58.176] LanguageService#OutliningSpans: {"events":{"InputDtsFile":867,"InputTsFile":153,"AnalyzeComponent":1,"TraitAnalyze":1,"TraitReuseAnalysis":72,"SourceFileReuseAnalysis":115,"GenerateTcb":1,"UpdateTypeCheckProgram":1},"phases":{"Unaccounted":1104,"Reconciliation":487,"Analysis":7388,"Resolve":85618,"TcbUpdateProgram":20341,"OutliningSpans":5849},"memory":{"Initial":364404276,"Analysis":369337260,"Resolve":369176228,"TtcUpdateProgram":372066504}}
Perf 1633 [21:58:58.196] LanguageService#LsDiagnostics: {"events":{},"phases":{"Unaccounted":6,"TtcDiagnostics":15733,"TtcSymbol":2269,"LsDiagnostics":1393},"memory":{}}
Perf 1634 [21:58:58.197] LanguageService#LSComputeApplicableRefactorings: {"events":{},"phases":{"Unaccounted":2},"memory":{}}
Info 1635 [21:58:58.966] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1636 [21:58:58.984] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 62 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 17.711708999995608ms
Info 1637 [21:58:58.984] Different program with same set of files
Info 1638 [21:58:59.17] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1639 [21:58:59.33] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 63 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 15.792500000010477ms
Info 1640 [21:58:59.33] Different program with same set of files
Perf 1641 [21:58:59.33] LanguageService#OutliningSpans: {"events":{"InputDtsFile":867,"InputTsFile":153,"AnalyzeComponent":1,"TraitAnalyze":1,"TraitReuseAnalysis":72,"SourceFileReuseAnalysis":115,"GenerateTcb":1,"UpdateTypeCheckProgram":1},"phases":{"Unaccounted":1174,"Reconciliation":485,"Analysis":8272,"Resolve":19719,"TcbUpdateProgram":16288,"OutliningSpans":3223},"memory":{"Initial":372232388,"Analysis":371430408,"Resolve":371456736,"TtcUpdateProgram":373847748}}
Perf 1642 [21:58:59.34] LanguageService#LSComputeApplicableRefactorings: {"events":{},"phases":{"Unaccounted":2},"memory":{}}
Perf 1643 [21:58:59.82] LanguageService#LsDiagnostics: {"events":{},"phases":{"Unaccounted":6,"TtcDiagnostics":13173,"TtcSymbol":1854,"LsDiagnostics":1171},"memory":{}}
Info 1644 [21:58:59.725] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1645 [21:58:59.744] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 64 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 19.057417000003625ms
Info 1646 [21:58:59.744] Different program with same set of files
Info 1647 [21:58:59.778] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1648 [21:58:59.794] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 65 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 15.88337500000489ms
Info 1649 [21:58:59.794] Different program with same set of files
Perf 1650 [21:58:59.795] LanguageService#OutliningSpans: {"events":{"InputDtsFile":867,"InputTsFile":153,"AnalyzeComponent":1,"TraitAnalyze":1,"TraitReuseAnalysis":72,"SourceFileReuseAnalysis":115,"GenerateTcb":1,"UpdateTypeCheckProgram":1},"phases":{"Unaccounted":1198,"Reconciliation":477,"Analysis":5202,"Resolve":23545,"TcbUpdateProgram":16418,"OutliningSpans":3645},"memory":{"Initial":375375068,"Analysis":378779120,"Resolve":378876376,"TtcUpdateProgram":381365884}}
Perf 1651 [21:58:59.840] LanguageService#LsDiagnostics: {"events":{},"phases":{"Unaccounted":6,"TtcDiagnostics":12409,"TtcSymbol":1758,"LsDiagnostics":1237},"memory":{}}
Info 1652 [21:59:0.142] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1653 [21:59:0.157] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 66 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 14.964708999992581ms
Info 1654 [21:59:0.157] Different program with same set of files
Info 1655 [21:59:0.184] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1656 [21:59:0.202] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 67 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 15.069499999983236ms
Info 1657 [21:59:0.202] Different program with same set of files
Perf 1658 [21:59:0.202] LanguageService#OutliningSpans: {"events":{"InputDtsFile":867,"InputTsFile":153,"AnalyzeComponent":1,"TraitAnalyze":1,"TraitReuseAnalysis":72,"SourceFileReuseAnalysis":115,"GenerateTcb":1,"UpdateTypeCheckProgram":1},"phases":{"Unaccounted":985,"Reconciliation":409,"Analysis":4953,"Resolve":17151,"TcbUpdateProgram":18525,"OutliningSpans":3129},"memory":{"Initial":382046320,"Analysis":385456068,"Resolve":385710068,"TtcUpdateProgram":388525788}}
Perf 1659 [21:59:0.203] LanguageService#LSComputeApplicableRefactorings: {"events":{},"phases":{"Unaccounted":4},"memory":{}}
Perf 1660 [21:59:0.265] LanguageService#LsDiagnostics: {"events":{},"phases":{"Unaccounted":8,"TtcDiagnostics":18682,"TtcSymbol":2554,"LsDiagnostics":1737},"memory":{}}
Info 1661 [21:59:0.614] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1662 [21:59:0.632] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 68 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 17.640333999996074ms
Info 1663 [21:59:0.632] Different program with same set of files
Info 1664 [21:59:0.663] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1665 [21:59:0.677] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 69 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 14.277124999993248ms
Info 1666 [21:59:0.677] Different program with same set of files
Perf 1667 [21:59:0.681] LanguageService#LsCompletions: {"events":{"InputDtsFile":867,"InputTsFile":153,"AnalyzeComponent":1,"TraitAnalyze":1,"TraitReuseAnalysis":72,"SourceFileReuseAnalysis":115,"GenerateTcb":1,"UpdateTypeCheckProgram":1},"phases":{"Unaccounted":1172,"Reconciliation":483,"Analysis":5695,"Resolve":20724,"TcbUpdateProgram":14730,"TtcSymbol":2052,"LsCompletions":4520},"memory":{"Initial":388940628,"Analysis":392356004,"Resolve":392492296,"TtcUpdateProgram":395577764}}
Perf 1668 [21:59:0.699] LanguageService#LsCompletions: {"events":{},"phases":{"Unaccounted":6,"TtcSymbol":1,"LsCompletions":10440},"memory":{}}
Perf 1669 [21:59:0.826] LanguageService#OutliningSpans: {"events":{},"phases":{"Unaccounted":14,"OutliningSpans":66},"memory":{}}
Perf 1670 [21:59:0.865] LanguageService#LSComputeApplicableRefactorings: {"events":{},"phases":{"Unaccounted":5},"memory":{}}
Perf 1671 [21:59:0.932] LanguageService#LsDiagnostics: {"events":{},"phases":{"Unaccounted":7,"TtcDiagnostics":15159,"TtcSymbol":1745,"LsDiagnostics":1347},"memory":{}}
Perf 1672 [21:59:1.573] LanguageService#LsCompletions: {"events":{},"phases":{"Unaccounted":8,"TtcSymbol":2,"LsCompletions":539},"memory":{}}
Info 1673 [21:59:3.429] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1674 [21:59:3.449] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 70 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 20.64175000000978ms
Info 1675 [21:59:3.450] Different program with same set of files
Info 1676 [21:59:3.490] Starting updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json
Info 1677 [21:59:3.507] Finishing updateGraphWorker: Project: /Users/ilanlappy/Projects/jumproom-web/src/app/tsconfig.json projectStateVersion: 71 projectProgramVersion: 8 structureChanged: false structureIsReused:: Completely Elapsed: 16.11454199999571ms
Info 1678 [21:59:3.507] Different program with same set of files
Perf 1679 [21:59:3.507] LanguageService#OutliningSpans: {"events":{"InputDtsFile":867,"InputTsFile":153,"AnalyzeComponent":1,"TraitAnalyze":1,"TraitReuseAnalysis":72,"SourceFileReuseAnalysis":115,"GenerateTcb":1,"UpdateTypeCheckProgram":1},"phases":{"Unaccounted":1199,"Reconciliation":486,"Analysis":10723,"Resolve":21300,"TcbUpdateProgram":16631,"OutliningSpans":6745},"memory":{"Initial":359889924,"Analysis":359101432,"Resolve":364820820,"TtcUpdateProgram":362172864}}
Perf 1680 [21:59:3.507] LanguageService#LSComputeApplicableRefactorings: {"events":{},"phases":{"Unaccounted":1},"memory":{}}
Perf 1681 [21:59:3.596] LanguageService#LsDiagnostics: {"events":{},"phases":{"Unaccounted":7,"TtcDiagnostics":27681,"TtcSymbol":24941,"LsDiagnostics":18170},"memory":{}}

Screenshots

Prior to pressing tab
Image

Immediately after pressing tab
Image

🌍 Your Environment

Angular Version:


Angular CLI: 19.0.6
Node: 18.20.5
Package Manager: npm 8.5.4
OS: darwin arm64

Angular: 19.0.5
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.1900.6
@angular-devkit/core         19.0.6 (cli-only)
@angular-devkit/schematics   19.0.6
@angular/build               19.0.6
@angular/cdk                 19.0.4
@angular/cli                 19.0.6
@schematics/angular          19.0.6
rxjs                         7.8.1
typescript                   5.6.3
zone.js                      0.15.0

Extension Version:


Identifier: angular.ng-template
Version: 19.0.4
Last Updated: 2025-01-14, 13:03:40
Size: 66.9 MB

VSCode Version:


Version: 1.96.4 (Universal)
Commit: cd4ee3b1c348a13bafd8f9ad8060705f6d4b9cba
Date: 2025-01-16T00:16:19.038Z (2 wks ago)
Electron: 32.2.6
ElectronBuildId: 10629634
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Darwin arm64 23.3.0

Operating System:


Apple M1 Max
32GB memory
osx Sonoma 14.3

Extension options:


N/A (after turning the logging back off)

Anything else relevant?
@atscott
Copy link
Collaborator

atscott commented Mar 27, 2025

I haven't been able to reproduce this issue myself. Is this still a problem for you and if so, can you provide a minimal project in a github repo?

@thepuzzlemaster
Copy link
Author

Thanks very much for the followup @atscott. Your comment got me thinking that maybe it was another extension causing an issue, so I upgraded vscode to the latest and disabled all extensions other than the angular language server, but it still repro'd for me.

I created a minimal repro here.

Steps to reproduce:

  • Open src/app/app.component.html
  • Start typing [$stringValue] in the <app-foo /> tag.
  • Press tab to autocomplete the input name before tying out the full string value

For me, it clears out the entire string and i'm left with []=""

Does autocomplete work normally for you when selecting the $stringValue option from the autocomplete list?

@atscott
Copy link
Collaborator

atscott commented Mar 27, 2025

Okay, thanks. I'm able to reproduce this now. I believe this is going to be a problem with the snippet completions and needing to escape the dollar sign. Should be reasonably simple to fix

atscott added a commit to atscott/angular that referenced this issue Mar 27, 2025
@atscott
fix(language-service): Ensure dollar signs are escaped in completions
3fae4c5 
Dollar signs need to be escaped so they are not replaced during snippet
expansion: https://code.visualstudio.com/docs/editing/userdefinedsnippets#_how-do-i-have-a-snippet-place-a-variable-in-the-pasted-script

fixes angular/vscode-ng-language-service#2139
atscott added a commit to angular/angular that referenced this issue Apr 3, 2025
@atscott
fix(language-service): Ensure dollar signs are escaped in completions (…
fcdef10 
…#60597)

Dollar signs need to be escaped so they are not replaced during snippet
expansion: https://code.visualstudio.com/docs/editing/userdefinedsnippets#_how-do-i-have-a-snippet-place-a-variable-in-the-pasted-script

fixes angular/vscode-ng-language-service#2139

PR Close #60597
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug needs clarification needs repro
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atscott @thepuzzlemaster