Skip to content

Commit b9cf414

Browse files
committed
fix(language-service): Ensure dollar signs are escaped in completions (#60597)
Dollar signs need to be escaped so they are not replaced during snippet expansion: https://code.visualstudio.com/docs/editing/userdefinedsnippets#_how-do-i-have-a-snippet-place-a-variable-in-the-pasted-script fixes angular/vscode-ng-language-service#2139 PR Close #60597
1 parent a22b13f commit b9cf414

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/language-service/src/attribute_completions.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ export function buildAttributeCompletionTable(
409409
}
410410

411411
function buildSnippet(insertSnippet: true | undefined, text: string): string | undefined {
412-
return insertSnippet ? `${text}="$1"` : undefined;
412+
return insertSnippet ? `${text.replace(/\$/gi, '\\$')}="$1"` : undefined;
413413
}
414414

415415
/**

0 commit comments

Comments
 (0)