Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk/menu): avoid re-opening the menu on enter #30263

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 2, 2025

Fixes that the CDK menu was re-opening immediately on enter presses on elements that aren't buttons or links.

Fixes #30250.

Fixes that the CDK menu was re-opening immediately on enter presses on elements that aren't buttons or links.

Fixes angular#30250.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 2, 2025
@crisbeto crisbeto requested a review from a team as a code owner January 2, 2025 08:39
@crisbeto crisbeto requested review from amysorto and andrewseguin and removed request for a team January 2, 2025 08:39
@crisbeto crisbeto removed the request for review from andrewseguin January 2, 2025 16:37
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 2, 2025
@crisbeto crisbeto merged commit 52758be into angular:main Jan 2, 2025
22 of 25 checks passed
crisbeto added a commit that referenced this pull request Jan 2, 2025
Fixes that the CDK menu was re-opening immediately on enter presses on elements that aren't buttons or links.

Fixes #30250.

(cherry picked from commit 52758be)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: cdk/menu target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(cdkMenuItem): Pressing "Enter" on non-button and non-anchor elements reopens the menu unexpectedly.
2 participants