Skip to content

allow federation-config as esm and sync/async exporting of config #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

allow federation-config as esm and sync/async exporting of config #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/native-federation-core/src/lib/config/share-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import path = require('path');
import fs = require('fs');
import path from 'path';
import fs from 'fs';
import { cwd } from 'process';
import { SharedConfig } from './federation-config';
import {
Expand Down
10 changes: 7 additions & 3 deletions libs/native-federation-core/src/lib/core/load-federation-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ export async function loadFederationConfig(
throw new Error('Expected ' + fullConfigPath);
}

const config = (await import(fullConfigPath)) as NormalizedFederationConfig;
return config;
}
const fnOrConfig = (await import('file://' + fullConfigPath) as any).default;
return Promise.resolve(
typeof fnOrConfig === 'function' ?
fnOrConfig() :
fnOrConfig);
};

1 change: 1 addition & 0 deletions libs/native-federation-core/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"extends": "../../tsconfig.base.json",
"compilerOptions": {
"module": "commonjs",
"moduleResolution": "node16",
"forceConsistentCasingInFileNames": true,
"strict": true,
"noImplicitOverride": true,
Expand Down
2 changes: 1 addition & 1 deletion libs/native-federation/src/builders/build/builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export async function* runBuilder(
}

if (!write && output.outputFiles) {
memResults.add(output.outputFiles.map((file) => new EsBuildResult(file)));
memResults.add(output.outputFiles.map((file) => new EsBuildResult(file as any)));
}

if (!write && output.assetFiles) {
Expand Down
4 changes: 2 additions & 2 deletions libs/native-federation/src/utils/angular-esbuild-adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ async function runEsbuild(
platform: 'browser',
format: 'esm',
target: ['esnext'],
plugins: plugins || [
plugins: plugins || ([
createCompilerPlugin(
pluginOptions.pluginOptions,
pluginOptions.styleOptions
Expand Down Expand Up @@ -287,7 +287,7 @@ async function runEsbuild(
...(mappedPaths && mappedPaths.length > 0
? [createSharedMappingsPlugin(mappedPaths)]
: []),
],
] as esbuild.Plugin[]),
define: {
...(!dev ? { ngDevMode: 'false' } : {}),
ngJitMode: 'false',
Expand Down
Loading