fix: Irrelevant Quick Fixes after applying code action

Fixes redhat-developer#410

Signed-off-by: azerr <[email protected]>

src/main/java/com/redhat/devtools/lsp4ij/features/codeAction/LSPLazyCodeActionIntentionAction.java

@@ -122,13 +122,26 @@ private void apply(@Nullable CodeAction codeaction,
                 executeCommand(codeaction.getCommand(), file, editor, languageServerItem);
             }
         }
+        // After applying code action, evict the code actions cache
+        // to avoid providing irrelevant Quick Fixes.
+        clearCodeActionsCache();
     }
 
-    private static void executeCommand(@NotNull Command command,
+    /**
+     * Clear code actions cache if needed.
+     */
+    private void clearCodeActionsCache() {
+        if (lazyCodeActions != null) {
+            lazyCodeActions.clear();
+        }
+    }
+
+    private void executeCommand(@NotNull Command command,
                                 @NotNull PsiFile file,
                                 @NotNull Editor editor,
                                 @NotNull LanguageServerItem languageServer) {
         CommandExecutor.executeCommand(new LSPCommandContext(command, file, LSPCommandContext.ExecutedBy.CODE_ACTION, editor, languageServer));
+        clearCodeActionsCache();
     }
 
     private LanguageServerItem getLanguageServer() {

src/main/java/com/redhat/devtools/lsp4ij/features/codeAction/LSPLazyCodeActionProvider.java

@@ -24,4 +24,9 @@ public interface LSPLazyCodeActionProvider {
      * @return a code action at the given index and false otherwise.
      */
     Either<CodeActionData, Boolean /* false when code action is not already loaded*/> getCodeActionAt(int index);
+
+    /**
+     * Clear code actions cache.
+     */
+    void clear();
 }

src/main/java/com/redhat/devtools/lsp4ij/features/codeAction/intention/LSPIntentionCodeActionSupport.java

@@ -145,4 +145,9 @@ private static boolean isValidCodeAction(@Nullable Either<org.eclipse.lsp4j.Comm
         }
         return true;
     }
+
+    @Override
+    public void clear() {
+        super.cancel();
+    }
 }

src/main/java/com/redhat/devtools/lsp4ij/features/codeAction/quickfix/LSPLazyCodeActions.java

@@ -193,4 +193,10 @@ public void cancel() {
             lspCodeActionRequest.cancel(true);
         }
     }
+
+    @Override
+    public void clear() {
+        cancel();
+        lspCodeActionRequest = null;
+    }
 }