Repository navigation
Tests: the inbox transcript fixture sizes elements by client box too - #390
Merged
Merged
Conversation
@tanstack/virtual-core 3.19.6 (TanStack/virtual#1326) measures the scroll viewport with clientWidth/clientHeight instead of offsetWidth/offsetHeight. The inbox attachments test gave happy-dom elements a 640 x 640 viewport through the offset box only, so under 3.19.6 the transcript measured 0 x 0, rendered no rows, and "an attachment in the conversation previews in Related" could not find the attachment. The stack lane resolves dependencies fresh (pnpm 11's one-day minimum release age made 3.19.6 eligible on 2026-10-17 ~11:20 UTC), so the lane went red on main and on every open PR from then on. The fixture now sizes both boxes, so it models a viewport whichever one the virtualizer measures. Browsers report real client sizes; product code is unaffected. Claude-Session: https://claude.ai/code/session_01VvRPgo3mVuL9ULgDSeZGBV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the
stackcheck, which has been red on main and on every open PR since 2026-10-17 around 11:20 UTC.What broke.
addons/angee/nexus/web/src/inbox/attachments.native.test.tsx› "an attachment in the conversation previews in Related" can't find therenewal-2.pdfbutton. Main's own commit e93cd60 fails it on a rerun now.Why.
@tanstack/virtual-core3.19.6, published 2026-10-16 11:18 UTC (fix(virtual-core): measure the visible scroll viewport TanStack/virtual#1326, "Measure the scroll viewport using client dimensions"), changedgetRectfromoffsetWidth/offsetHeighttoclientWidth/clientHeight.stackcheck runspnpm install --no-frozen-lockfile, and pnpm 11 waits one day before using a new release. So 3.19.6 reached CI about 24 hours after publication, between a passing run at 10:43 UTC and the first failure at 13:37 UTC.@tanstack/react-virtual3.14.21 and@tanstack/virtual-core3.19.6.Change. The fixture stubs the client box as well as the offset box, so it models a viewport whichever box the virtualizer measures. The framework's own lockfile still has the older version.
Product code is unaffected: browsers report real client sizes, and the change improves end-aligned rows.
Tests: this PR's own
stackcheck runs the test against 3.19.6.https://claude.ai/code/session_01VvRPgo3mVuL9ULgDSeZGBV