Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom css to fix external depenceny upload restriction #8

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

nezhar
Copy link
Contributor

@nezhar nezhar commented Nov 29, 2023

This is required due to a restirction of PEP 440 and PEP 508 - pypi/warehouse#7136 (comment)

Log from https://github.com/anexia/django-future-tasks/actions/runs/7032213426/job/19135487570#step:7:20

Run twine upload dist/*
  twine upload dist/*
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.8.18/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.8.18/x64/lib
    TWINE_REPOSITORY: ***
    TWINE_USERNAME: ***
    TWINE_PASSWORD: ***
    TWINE_NON_INTERACTIVE: yes
Uploading distributions to https://upload.***.org/legacy/
Uploading django_future_tasks-1.1.0-py3-none-any.whl
[2](https://github.com/anexia/django-future-tasks/actions/runs/7032213426/job/19135487570#step:7:2)5l
  0% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0.0/21.1 kB • --:-- • ?
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 21.1/21.1 kB • 00:00 • [3](https://github.com/anexia/django-future-tasks/actions/runs/7032213426/job/19135487570#step:7:3)8.6 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 21.1/21.1 kB • 00:00 • 38.6 MB/s
100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 21.1/21.1 kB • 00:00 • 38.6 MB/s
25hWARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: [4](https://github.com/anexia/django-future-tasks/actions/runs/7032213426/job/19135487570#step:7:4)00 Bad Request from [https://upload.***.org/legacy/](https://upload.%2A%2A%2A.org/legacy/)        
         Invalid value for requires_dist. Error: Can't have direct dependency:  
         'django-cronfield @                                                    
         git+https://github.com/galipnik/[email protected]
         '                                                                      
Error: Process completed with exit code 1.

It uses the latest release of django-cronfield and moves the css fixes as owerides in this repository.

We can revert this once knaperek/django-cronfield#3 is merged and there is a new release.

@nezhar nezhar requested a review from galipnik November 29, 2023 12:56
@nezhar nezhar force-pushed the fixes_requires_dist branch from 5c68799 to 8cbf2b3 Compare November 29, 2023 12:58
@nezhar nezhar force-pushed the fixes_requires_dist branch from 8cbf2b3 to 1997c89 Compare November 30, 2023 09:48
Copy link
Member

@galipnik galipnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks!

@nezhar nezhar merged commit b6a8b42 into main Nov 30, 2023
24 checks passed
@nezhar nezhar deleted the fixes_requires_dist branch August 29, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants