Allow seconds in cron string settings #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
Apart from the two comments above: LGTM. |
galipnik
suggested changes
Jul 22, 2024
django_future_tasks/migrations/0007_alter_periodicfuturetask_cron_string.py
Outdated
Show resolved
Hide resolved
nezhar
force-pushed
the
cron_seconds
branch
2 times, most recently
from
839e97d to
9346d38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax for specifying seconds in a cron job is not standardized, as traditional Unix cron does not include a field for seconds. For more information, see https://en.wikipedia.org/wiki/Cron#Cron_expression.
We currently use two libraries with different approaches to specifying seconds:
croniter: https://github.com/kiorky/croniter/blob/master/src/croniter/tests/test_croniter.py#L39* * * * * */15: Every 15 secondscron-descriptor: https://github.com/Salamek/cron-descriptor/blob/master/tests/TestFormats.py#L59*/15 * * * * *: Every 15 secondsThis pull request removes the cron description from the Admin interface and drops the
cron-descriptorlibrary from the requirements. Instead, the syntax ofcroniteris used, as it ensures that configurations without seconds are still compatible.