Skip to content

filter by username is now deprecated #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

filter by username is now deprecated #718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions cloud/user.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,14 +241,6 @@ func WithInactive(inactive bool) UserSearchF {
}
}

// WithUsername sets the username to search
func WithUsername(username string) UserSearchF {
return func(s UserSearch) UserSearch {
s = append(s, UserSearchParam{name: "username", value: username})
return s
}
}

// WithAccountId sets the account id to search
func WithAccountId(accountId string) UserSearchF {
return func(s UserSearch) UserSearch {
Expand Down Expand Up @@ -283,7 +275,7 @@ func (s *UserService) Find(ctx context.Context, property string, tweaks ...UserS
search = f(search)
}

var queryString = ""
queryString := ""
for _, param := range search {
queryString += param.name + "=" + param.value + "&"
}
Expand Down