Skip to content

Fix RuntimeException, remove jcenter and upgrade dependencies #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: start_kotlin
Choose a base branch
from

Conversation

PierreVieira
Copy link

@PierreVieira PierreVieira commented Nov 1, 2021

Note: This PR guarantees the perfect functioning of the application after all changes.

What is the main problem?

Crash when trying to launch the app on a device with resolution equal to or above xxhdpi.

What does this PR do?

  • Fix runtime exception describes at Crash when starting the app on branch start_kotlin using xxhdpi device #257
  • Replacement of jcenter (deprecated) by mavenCentral;
  • Upgrade from agp: 4.1.2 -> 7.0.3;
  • Kotlin upgrade: 1.4.30 -> 1.5.31;
  • sdk target upgrade: 29 -> 31 (it was necessary to add the tag android:exported="true" in the manifest file);
  • Need to use template string due to nullability of second parameter of Log.e in line 98 in WorkerUtils.kt;

How to test?

Just build the app.


Close: #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant