fix(windows): stop Settings→Recent freeze from sync cmd /C ver - #388
Open
HaoChiBao wants to merge 2 commits into
Open
fix(windows): stop Settings→Recent freeze from sync cmd /C ver#388HaoChiBao wants to merge 2 commits into
HaoChiBao wants to merge 2 commits into
Conversation
get_dictation_status was spawning a process on the UI thread when the composer remounted after leaving Settings. Query OsVersion in-process instead. Fixes andrewyng#181
A parked approval could finish and clear the guard before a duplicate spawn from a stale due() snapshot took its first step, so the task ran twice (intermittent assert 2 == 1 in CI). Also adds a regression test for the approval-lands-on-tick race.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_dictation_statusand was spawningcmd /C veron the UI thread — freezing Windows for ~2–4 seconds (coming out of setting to recent tab on wondow giving a 2-4 seconds screen freez #181).windows-versionOsVersionquery (Windows-only dependency).Test plan
cargo test --manifest-path surfaces/gui/src-tauri/Cargo.toml voice_input_compatibility_testsFixes #181