Fix display scaling scroll issue in connector integration - #346
Open
manavshrivastavagit wants to merge 1 commit into
Open
Fix display scaling scroll issue in connector integration#346manavshrivastavagit wants to merge 1 commit into
manavshrivastavagit wants to merge 1 commit into
Conversation
…iews Add min-h-0 to <main> elements across surface views to fix CSS grid overflow clipping at non-default display scales. Root cause: the .app grid's <main> items had default min-height: auto, causing them to grow beyond the viewport when content was tall (e.g., increased display scaling). Since .app has overflow: hidden, the overflow was silently clipped with no scrollbar. Adding min-h-0 (min-height: 0) allows grid items to shrink below their intrinsic content height, letting the inner overflow-y-auto div properly constrain and scroll. Fixes andrewyng#321
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #321 — connector integration content is cut off at increased display scales with no scrollbar.
Root cause
The .app\ grid (\display: grid; overflow: hidden) contains <main>\ elements as grid items. These grid items had default \min-height: auto, causing them to grow beyond the viewport when content was tall (e.g., at non-default display scaling). Since the parent grid has \overflow: hidden, the overflow was silently clipped with no scrollbar appearing.
Adding \min-h-0\ (\min-height: 0) allows the grid items to shrink below their intrinsic content height, letting the inner \overflow-y-auto\ div properly constrain and scroll.
Changes
Testing