Skip to content

Make encoding/buffer overrideable #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make encoding/buffer overrideable #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ waveform(audiofile, {
'png-color-bg': '00000000', // bg color, rrggbbaa
'png-color-center': '000000ff', // gradient center color, rrggbbaa
'png-color-outer': '000000ff', // gradient outer color, rrggbbaa

// node-specific options
encoding: "utf8", // different output encoding for callback (default is 'buffer')
maxBuffer: 1024 * 1000 // max buffer before the process is killed (default is 1024 * 5000)

}, function(err, buf) {
// done
});
Expand Down
9 changes: 8 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,26 @@ var flagNames = {
'wjs-plain': true,
};

var processOptions = {
encoding: 'buffer',
maxBuffer: 5000 * 1024
};

module.exports = function(audiofile, options, callback) {
var cmdline = [audiofile];
for (var optName in options) {
if (flagNames[optName]) {
cmdline.push('--' + optName);
} else if (processOptions[optName]){
processOptions[optName] = options[optName];
} else {
var value = options[optName];
cmdline.push('--' + optName);
cmdline.push(value);
}
}

execFile(waveformBin, cmdline, {encoding: 'buffer', maxBuffer: 5000*1024}, function(err, stdout, stderr) {
execFile(waveformBin, cmdline, processOptions, function(err, stdout, stderr) {
if (err) {
err.stdout = stdout;
err.stderr = stderr;
Expand Down