Add launchd / systemd support #78
Conversation
Add server example script
|
This looks like a cool feature. It's a little beyond what I am able to review and test at this time. Would you be willing to rebase it against current master and then wait for one or two other people to review and test it? |
There was a problem hiding this comment.
I'm not 100% sure, but I suspect the test here could be wrong.
A non defined LISTEN_FD will result in a NaN value, so still truthy value.
Maybe this should be :
if (!isNaN(listenFd)) { ..
I'm not currently working on node stuff, so I would welcome someone else updating this. |
Same here. I've been working on Genesis and libsoundio. |
|
So it is impossible to use naught with systemd right now? |
4 participants
These changes attempt to implement the feature I requested in #65.
I made these changes many months ago, and they seemed to work at the time, but I have not looked at it since then. There has been a new version of naught released since then, and I don't know how naught changed since I wrote this.
The server example script I just committed was also written back then. I felt that naught was trying to recommend a variety of best practices, but not really showing a complete example of how to do that, so I tried to create one. I'm not confident that it is correctly exemplifying everything naught recommends, so it should be examined and fixed as needed.