-
Notifications
You must be signed in to change notification settings - Fork 0
Switch to vectorized Stokes solver and stop using steady-state itterations #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andrewdnolan
wants to merge
13
commits into
main
Choose a base branch
from
Adrien_suggestions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
d600c3a to
b3ac9fd
Compare
The hope is this will help with convergence issues for the periodic surging experiments.
With new solver setting, depth is not written on the first timestep if using a restat. This previously was treated as zero depth, resulting in infinite volumes. Now use backfilling of first non-zero volume to before relaitve volume is calculated inorder to avoid infs/nans
32129fb to
03b4db3
Compare
andrewdnolan
commented
Apr 19, 2025
Owner
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
source ./periodic_surge.sh
parse_params()
{
IFS=" " read -r QP beta NT T_0<<< $(sed -n "${1}p" "run/${KEY}/${KEY}.commands" | cut -d " " -f 7,9,11,13)
}
parse_runtime(){
runtime=$(tail logs/${KEY}/${KEY}_52723013_${1}.out | awk '/[S]OLVER TOTAL/ {print $5}')
}
SP=2
KEY='crmpt12'
offset=-0.35
# get the number of simulations to process
N=$(wc -l < "run/${KEY}/${KEY}.commands")
parse_json "params/${KEY}.json"
for j in $(seq $N);do
parse_params $j
parse_runtime $j
log_runtime $KEY $dx $T_ma $offset $ST_dt $SD_dt $QT_dt $QD_dt $SP $QP $TT $beta $runtime
done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This PR alters the Stokes solver and thermomechanical coupling strategy, in an attempt to address the persistent failure of some
betavalue in the03_PeriodicSurgeexperiment. There is no clear pattern of simulation failures as a function ofbetavalue too suggest it's a numerical stability problem. The failures manifests through the Stokes solver diverging and the large resulting velocities producing NaN strain heating values.Per personal communication with Adrien Gilbert, he has made two suggestion, which have been implemented in this PR:
Upside to both of these changes is they'll dramatically reduce simulation runtimes.