feat(config): move picker placement to [ui] with popup support - #37
Merged
Conversation
Sessionizer/Worktree pickers now open via [ui].placement (overlay|split|popup) with optional popup width/height. [layout] is bootstrap-only (focus).
New configs seed [ui].placement = "popup" with width/height 80%. Bump min_herdr_version and README prerequisites to match popup support.
Document picker vs bootstrap scope, popup 80% defaults, legacy [layout].placement migration, and preserve-[ui] when editing layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[layout]into[ui]so workspace bootstrap config stays about focus/tabs only.popupplacement (Herdr>= 0.7.4) with optional[ui].width/[ui].height(cells or percentages like"80%").overlaywhen[ui].placementis omitted; old[layout].placementis ignored (not a fallback).Config
Test plan
bun test(145 tests)[ui].placement = "popup"(+ size) → picker opens as Herdr popup[layout]without placement still loads and bootstraps workspaces