Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add range slider label #85

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifest.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "1.0.96",
"version": "1.1.0",
"manifest_version": 2,
"minimum_chrome_version": "51",
"name": "Code Pad Text Editor",
Expand Down
15 changes: 15 additions & 0 deletions src/css/main.css
Original file line number Diff line number Diff line change
Expand Up @@ -606,3 +606,18 @@ input.cmn-tgl-rnd-flt:checked + label:after {
.bootstrapMenu .dropdown-item .fa {
font-size: 0.9rem;
}

/*******************************************************************************/
/******************************** Range Slider Fix *****************************/
/*******************************************************************************/
.range-slider {
white-space: nowrap;
}

.range-slider > * {
display: inline-block;
}

.range-slider-range {
width: 95.5%;
}
18 changes: 13 additions & 5 deletions src/html/modals/editor/ide.settings.html
Original file line number Diff line number Diff line change
Expand Up @@ -178,18 +178,22 @@
<div class="form-group">
<label>
<strong>Tab size</strong><br/>
<span>#No. of columns per tab</span>
<span>Number of columns per tab</span>
</label>
<div class="range-slider">
<input data-toggle="tooltip"
<input id="tabSize"
data-toggle="tooltip"
data-action="ide-setting"
data-option="tabSize"
class="range-slider-range"
type="range"
min="1"
max="8"
step="1"
title="Tab size"/>
title="Tab size"/>

<label for="tabSize"
title="Default: 4, Current: 4">4</label>
</div>
</div>
</div>
Expand All @@ -198,10 +202,11 @@
<div class="form-group">
<label>
<strong>Word wrap limit</strong><br/>
<span>#No. of characters per line before wrapping</span>
<span>Number of characters per line before wrapping</span>
</label>
<div class="range-slider">
<input data-toggle="tooltip"
<input id="wrap"
data-toggle="tooltip"
data-action="ide-setting"
data-option="wrap"
class="range-slider-range"
Expand All @@ -210,6 +215,9 @@
max="128"
step="1"
title="Word wrap limit"/>

<label for="wrap"
title="Default: 68, Current: 68">68</label>
</div>
</div>
</div>
Expand Down
13 changes: 12 additions & 1 deletion src/js/events.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,18 @@ $(document).ready(function () {
//////////////////////////////////////////////////////////////////////////////////////////////////////////////////

$(document).on('input change', '[data-action="ide-setting"]', function () {
IdeSettings.persistAndApply(IdeSettings.getKeyValFromEl($(this)));
let $this = $(this);
let $next = $(this).next();

IdeSettings.persistAndApply(IdeSettings.getKeyValFromEl($this));

if ($this.hasClass('range-slider-range')) {
$next.text($this.val());

let title = $next.attr('title').split(', ');
title[1] = 'Current: ' + $this.val();
$next.attr('title', title.join(', '));
}
});

//////////////////////////////////////////////////////////////////////////////////////////////////////////////////
Expand Down