Fix bug in HLS streamer where the final segment fails to play or stream #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We identified a critical bug in our HLS streaming implementation where the final segment of a stream fails to play or stream under specific scenarios. This issue was affecting the viewer's experience, especially in cases of closely timed live events or content that runs right up to the last segment.
Solution
This merge request introduces a fix that ensures the final segment of the HLS stream is correctly processed and played. The modifications include adjustments to the segment handling logic to ensure the last part of the stream is not omitted or dropped during the streaming process.