Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features: Easier input of schedule & Allows blacklist to be loaded from text file #44

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shivgodhia
Copy link

@shivgodhia shivgodhia commented Apr 24, 2020

Hi, I made a simple but useful change to the code.

Schedule Input
Now, in config.json for scheduling, instead of just writing a number for the day, such as 1 or 3 for Monday and Wednesday respectively, you have more options:

  • "weekdays" will use Monday to Friday
  • "weekends" will use Saturday and Sunday
  • Also have list option such as [1,3,5] for Monday, Wednesday and Friday or [1,2,3,4,5,6], etc however you wish.

It still supports the earlier way of using the integer representation of the day, as well as letting the value be None (which will be all 7 days of the week).

Blacklist import
Now you can also import a blacklist from a text file or a few text files so it is easier to fill in the config.json and even create separate blacklist categories to be toggled on and off.

@shivgodhia shivgodhia changed the title Feature: Easier input of schedule Features: Easier input of schedule & Allows blacklist to be loaded from text file Apr 24, 2020
@andreasgrill
Copy link
Owner

Thanks for your commits, I like the idea of simplifying the configuration!
Due to the latest changes to support SelfControl 3 there are now merge conflicts. If you'd resolve them, I'll merge your changes; or I could integrate them when I have time. Just let me know if you want me to resolve them.

@shivgodhia
Copy link
Author

Thanks for your commits, I like the idea of simplifying the configuration!
Due to the latest changes to support SelfControl 3 there are now merge conflicts. If you'd resolve them, I'll merge your changes; or I could integrate them when I have time. Just let me know if you want me to resolve them.

You're welcome! I have resolved the changes and it should work now, though I must admit I don't use Self Control anymore so I didn't manage to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants