Closed
Conversation
+ cleanup
# Conflicts: # TinyEcs.sln
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new C# source generator for TinyEcs that automatically generates adapter classes for methods decorated with the [TinySystem] attribute. This modernizes the system registration process by providing compile-time code generation instead of manual system creation.
Key changes:
- Add source generator that creates adapter classes for
[TinySystem]methods - Refactor system architecture to use new adapter pattern with
ITinySysteminterface - Update samples to demonstrate the new attribute-based system definition
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/TinyEcs.SourceGenerator/Program.cs | Main source generator that analyzes methods with [TinySystem] and generates adapter classes |
| tools/TinyEcs.SourceGenerator/IndentedStringBuilder.cs | String builder utility for generating properly formatted C# code |
| src/Bevy.cs | Major refactoring introducing new system architecture with ITinySystem interface and Stage-based scheduling |
| samples/MyBattleground/Program.cs | Updated to use the new [TinySystem] attribute for system definitions |
| samples/TinyEcsGame/Program.cs | Updated to use the new system architecture and attribute-based systems |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Owner
Author
|
I dont like it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.