Fix Pre-Populated database for Windows #550
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include Windows pre-populated instructions
(If the db already exists, that's not a problem)
chrisglein
reviewed
Jan 11, 2023
chrisglein
reviewed
Jan 13, 2023
Works as suggested without change Co-authored-by: Chris Glein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The issue stemmed from two separate places.
.GetResults()seems to have been used as an attemptedawait, but does not function that way. Replaced with.get()which does.FailIfExistson the copy function, which is correct if you don't want to overwrite, but then they were returning without loading the database at all if that error fired. Replaced with a check for the error thrown byFailIfExists, which is ignored, while retaining error-checking for other types of failures (although I don't know what those would be).Resolutions
resolves #519, resolves #491, resolves #487, resolves #451