Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sqlite libraries for Android native #492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leorajdsouza
Copy link

Updating the code lib fixed the #462 issue.

Tested Environments:
RN: 0.62.1
Device: S21 Android 11

@rblalock
Copy link

Ohhh interesting. sounds like this is my problem too

@rblalock
Copy link

Is there anything I can do to help get this through? Testing? etc?

@zzorba
Copy link

zzorba commented Oct 12, 2021

Quite interested in this as well, especially on builds with targetSdkVersion: 30, which became standard with RN 65+. By my read targeting version 30 causes Android to enforce the new file system permissions fully.

@rblalock
Copy link

@zzorba Ref. my comment here, maybe it'll help? #462 (comment)

@zzorba
Copy link

zzorba commented Oct 12, 2021

@rblalock thank you for this suggestion, I was strongly considering moving back to the built in SQLite, I just was trying to remember why I might have put the embedded version in to begin with.

Edit: and as I suspected, supporting old android versions forced me to use the full SQLite implementation, since older OSes don't support the on conflict operations that typeorm is using in my current setup.

@andpor
Copy link
Owner

andpor commented Oct 20, 2021

There are conflicts. Also, can you confirm if all required functionality/features for native libs are working fine (use JSON test file in examples directory). Please reach out to the contributor of those libraries to make sure everything is covered and working.

@andpor
Copy link
Owner

andpor commented Oct 20, 2021

Is there anything I can do to help get this through? Testing? etc?

Yes @rblalock - testing/validation would be great. I have seen people having issues with JSON support and other things glancing through the original issue.

adriancalvium added a commit to calvium/react-native-sqlite-storage that referenced this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants