Return to minimal logger interface #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add connect delay
Use current go idioms
fix: print original function code for exceptions
This was previously attempted with the flushAll call, but this doesn't seem to be reliable in practice - since it sets the read timeout to time.Now(), this means that in practice the Read in most cases actually returns directly without attempting to read. Instead of trying to extend the deadline for the flushing read by some arbitrary small value, this fix handles the problem at a different place: if we detect a transaction ID mismatch by 1, we simply ignore the response and assume that a matching response will follow. This required some refactoring of the reading code since just retrying the read without another write wasn't easily possible.
…match fix: retry reading query response on transaction id mismatch
…match feat(tcpclient): added skipping of transaction mismatches by more than one packet
Wrap open error with device name for context
Use time.Since
…ed by 2 when writing multiple registers
…ters Fix Modbus-CLI for WriteMultipleRegisters
Signed-off-by: Benedikt Bongartz <[email protected]>
feat(cmd/modbus-cli): support writing single coil
…odings feat(modbus-cli): add option to print out different encoding options
Upgrade to Go 1.19
Simplify logger implementation
Use embedded fields directly
Validate length of read result against request
…o to Debug when debugging logs were displayed
…ging the name to newLogger
Bump to Go version 1.21
Fix races in unit-tests
Implement Modbus UDP
Enhanced Logging Interface
Return data of too large responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.