Enable biome linting strict #274
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,35 @@ | ||||||||||||||||||
| { | ||||||||||||||||||
| "$schema": "https://biomejs.dev/schemas/2.3.8/schema.json", | ||||||||||||||||||
| "vcs": { | ||||||||||||||||||
| "enabled": true, | ||||||||||||||||||
| "clientKind": "git", | ||||||||||||||||||
| "useIgnoreFile": true | ||||||||||||||||||
| }, | ||||||||||||||||||
| "files": { | ||||||||||||||||||
| "ignoreUnknown": false, | ||||||||||||||||||
| "includes": ["**"] | ||||||||||||||||||
| }, | ||||||||||||||||||
| "formatter": { | ||||||||||||||||||
| "enabled": true, | ||||||||||||||||||
| "indentStyle": "space", | ||||||||||||||||||
| "indentWidth": 2, | ||||||||||||||||||
| "lineWidth": 100 | ||||||||||||||||||
| }, | ||||||||||||||||||
| "assist": { "actions": { "source": { "organizeImports": "on" } } }, | ||||||||||||||||||
| "linter": { | ||||||||||||||||||
| "enabled": true, | ||||||||||||||||||
| "rules": { | ||||||||||||||||||
| "recommended": true, | ||||||||||||||||||
| "correctness": { | ||||||||||||||||||
| "noUnusedVariables": "error" | ||||||||||||||||||
| } | ||||||||||||||||||
|
Comment on lines
+22
to
+25
Contributor
There was a problem hiding this comment. The PR title mentions enabling 'strict' linting, but the configuration only uses the This would enable all strict rules and keep your override for unused variables. If you only intended to enable the recommended rules, consider updating the PR title to avoid confusion.
Suggested change
|
||||||||||||||||||
| } | ||||||||||||||||||
| }, | ||||||||||||||||||
| "javascript": { | ||||||||||||||||||
| "formatter": { | ||||||||||||||||||
| "quoteStyle": "double", | ||||||||||||||||||
| "semicolons": "always", | ||||||||||||||||||
| "trailingCommas": "es5" | ||||||||||||||||||
| } | ||||||||||||||||||
| } | ||||||||||||||||||
| } | ||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While
vcs.useIgnoreFileis helpful, specifyingincludesmore explicitly is a best practice. Using"**"can be slow as it traverses all directories, which might include build artifacts or other files that are not in.gitignorebut are not meant to be linted. Scoping it down to your source files will improve performance and prevent unintended linting.