refactor: Improve base Modifier class design

src/modifiers/colormodifier.ts

@@ -129,7 +129,11 @@ class ColorModifier extends Modifier {
     this.computeName = undefined;
   }
 
-  runByProperty = (input: ModifierInput, output: ModifierOutput) => {
+  runByProperty = (
+    input: ModifierInput,
+    output: ModifierOutput,
+    everything: boolean = false,
+  ) => {
     if (!input.renderState.visualizer) {
       return;
     }
@@ -187,7 +191,9 @@ class ColorModifier extends Modifier {
     everything: boolean = false,
   ) => {
     if (
-      (this.previousColoringMethod === "type" && !output.colorsDirty) ||
+      (!everything &&
+        this.previousColoringMethod === "type" &&
+        !output.colorsDirty) ||
       !input.renderState.visualizer
     ) {
       return;
@@ -214,13 +220,17 @@ class ColorModifier extends Modifier {
     this.previousColoringMethod = "type";
   };
 
-  run = (input: ModifierInput, output: ModifierOutput) => {
+  run(
+    input: ModifierInput,
+    output: ModifierOutput,
+    everything: boolean = false,
+  ): void {
     if (this.computeName) {
-      this.runByProperty(input, output);
+      this.runByProperty(input, output, everything);
     } else {
-      this.runByType(input, output);
+      this.runByType(input, output, everything);
     }
-  };
+  }
 }
 
 export default ColorModifier;

src/modifiers/modifier.ts

@@ -5,7 +5,7 @@ interface ModifierProps {
   active: boolean;
 }
 
-class Modifier {
+abstract class Modifier {
   public name: string;
   public key: string;
   public active: boolean;
@@ -16,10 +16,10 @@ class Modifier {
     this.active = active;
   }
 
-  run = (
+  abstract run(
     input: ModifierInput,
     output: ModifierOutput,
-    everything: boolean = false,
-  ) => {};
+    everything?: boolean
+  ): void;
 }
 export default Modifier;

src/modifiers/syncbondsmodifier.ts

@@ -12,7 +12,11 @@ class SyncBondsModifier extends Modifier {
     super({ name, active });
   }
 
-  run = (input: ModifierInput, output: ModifierOutput) => {
+  run(
+    input: ModifierInput,
+    output: ModifierOutput,
+    _everything: boolean = false,
+  ): void {
     if (!this.active) {
       if (output.bonds) {
         output.bonds.count = 0;
@@ -43,7 +47,7 @@ class SyncBondsModifier extends Modifier {
       if (newBonds.mesh) {
         newBonds.mesh.count = numBonds;
       }
-      return newBonds;
+      return;
     }
 
     const bonds1Ptr = input.lammps.getBondsPosition1Pointer() / 4;
@@ -64,7 +68,7 @@ class SyncBondsModifier extends Modifier {
       newBonds.mesh.count = numBonds;
     }
     newBonds.markNeedsUpdate();
-  };
+  }
 }
 
 export default SyncBondsModifier;

src/modifiers/synccomputesmodifier.ts

@@ -11,11 +11,11 @@ class SyncComputesModifier extends Modifier {
     super({ name, active });
   }
 
-  run = (
+  run(
     input: ModifierInput,
     output: ModifierOutput,
     everything: boolean = false,
-  ) => {
+  ): void {
     if (!this.active || !input.hasSynchronized) {
       return;
     }
@@ -121,7 +121,7 @@ class SyncComputesModifier extends Modifier {
       }
       output.computes[name] = compute;
     }
-  };
+  }
 }
 
 export default SyncComputesModifier;

src/modifiers/syncfixesmodifier.ts

@@ -11,11 +11,11 @@ class SyncFixesModifier extends Modifier {
     super({ name, active });
   }
 
-  run = (
+  run(
     input: ModifierInput,
     output: ModifierOutput,
     everything: boolean = false,
-  ) => {
+  ): void {
     if (!this.active || !input.hasSynchronized) {
       return;
     }
@@ -116,7 +116,7 @@ class SyncFixesModifier extends Modifier {
       }
       output.fixes[name] = fix;
     }
-  };
+  }
 }
 
 export default SyncFixesModifier;

src/modifiers/syncparticlesmodifier.ts

@@ -12,11 +12,11 @@ class SyncParticlesModifier extends Modifier {
     super({ name, active });
   }
 
-  run = (
+  run(
     input: ModifierInput,
     output: ModifierOutput,
-    everything: boolean = false,
-  ) => {
+    _everything: boolean = false,
+  ): void {
     if (!this.active) {
       if (output.particles) {
         output.particles.count = 0;
@@ -75,8 +75,7 @@ class SyncParticlesModifier extends Modifier {
     }
 
     newParticles.markNeedsUpdate();
-    return newParticles;
-  };
+  }
 }
 
 export default SyncParticlesModifier;

src/modifiers/syncvariablesmodifier.ts

@@ -11,11 +11,11 @@ class SyncVariablesModifier extends Modifier {
     super({ name, active });
   }
 
-  run = (
+  run(
     input: ModifierInput,
     output: ModifierOutput,
     everything: boolean = false,
-  ) => {
+  ): void {
     if (!this.active || !input.hasSynchronized) {
       return;
     }
@@ -118,7 +118,7 @@ class SyncVariablesModifier extends Modifier {
       }
       output.variables[name] = variable;
     }
-  };
+  }
 }
 
 export default SyncVariablesModifier;