Add some proper testing

Author: ananace

.rubocop.yml

@@ -6,6 +6,7 @@ AllCops:
     - 'Rakefile'
     - 'vendor/**/*'
   NewCops: enable
+  SuggestExtensions: false
 
 # Don't enforce documentation
 Style/Documentation:

lib/grafana_matrix/renderer.rb

@@ -12,7 +12,7 @@ class Renderer
     }.freeze
 
     def render(data, rule, template)
-      erb = ERB.new template, 0, '-'
+      erb = ERB.new template, trim_mode: '-'
       erb.result(binding)
     end
 

lib/grafana_matrix/templates/html.erb

@@ -2,7 +2,7 @@
 <%- if data['imageUrl'] && rule.details? && data['state'] != 'ok' -%>
 <details><summary>
 <%-   unless data.fetch('message', '').empty? -%>
-<%= data['message'] %>
+<%= data['message'] %><br/>
 <%-   end -%>
 <%- else -%>
 <%-   unless data.fetch('message', '').empty? -%>

test/fixtures/message-details.html

@@ -0,0 +1,8 @@
+<h4><a href="https://grafana.example.com/panel-url" style="font-weight: bold; font-style: italic"><font color="#ed2e18">[Alerting] IO wait alert</font></a></h4>
+<details><summary>
+IO wait percentage averaged above 10% the last five minutes<br/>
+<b>node.example.com</b>: 14.45<br/>
+<b>node2.example.com</b>: 11.22<br/>
+</summary>
+<a href="https://grafana.example.com/panel-url"><img src="https://grafana.example.com/image.png" alt="" /></a>
+</details>

test/fixtures/message.html

@@ -0,0 +1,6 @@
+<h4><a href="https://grafana.example.com/panel-url" style="font-weight: bold; font-style: italic"><font color="#ed2e18">[Alerting] IO wait alert</font></a></h4>
+<p>IO wait percentage averaged above 10% the last five minutes</p>
+<b>node.example.com</b>: 14.45<br/>
+<b>node2.example.com</b>: 11.22<br/>
+<br/>
+<a href="https://grafana.example.com/panel-url"><img src="https://grafana.example.com/image.png" alt="" /></a>

test/fixtures/message.plain

@@ -0,0 +1,8 @@
+[Alerting] IO wait alert
+IO wait percentage averaged above 10% the last five minutes
+
+node.example.com: 14.45
+node2.example.com: 11.22
+
+Image: https://grafana.example.com/image.png
+URL: https://grafana.example.com/panel-url

test/grafana_matrix_test.rb

@@ -1,4 +1,4 @@
-require "test_helper"
+require 'test_helper'
 
 class GrafanaMatrixTest < Minitest::Test
   def test_that_it_has_a_version_number

test/renderer_test.rb

@@ -0,0 +1,33 @@
+require 'test_helper'
+
+class RendererTest < Minitest::Test
+  ALERTDATA = {
+    'title' => '[Alerting] IO wait alert',
+    'message' => 'IO wait percentage averaged above 10% the last five minutes',
+    'state' => 'alerting',
+    'evalMatches' => [
+      { 'metric' => 'node.example.com', 'value' => 14.45 },
+      { 'metric' => 'node2.example.com', 'value' => 11.22 },
+    ],
+    'imageUrl' => 'https://grafana.example.com/image.png',
+    'ruleUrl' => 'https://grafana.example.com/panel-url'
+  }.freeze
+  ALERTRULE = GrafanaMatrix::Config::Rule.new(nil, {}).freeze
+  ALERTRULE_DETAILS = GrafanaMatrix::Config::Rule.new(nil, { details_tag: true }).freeze
+
+  def setup
+    @renderer = GrafanaMatrix::Renderer.new
+  end
+
+  def test_that_it_renders_plain
+    assert_equal load_fixture('message.plain').read, @renderer.render_plain(ALERTDATA, ALERTRULE)
+  end
+
+  def test_that_it_renders_html
+    assert_equal load_fixture('message.html').read, @renderer.render_html(ALERTDATA, ALERTRULE)
+  end
+
+  def test_that_it_renders_html_with_details
+    assert_equal load_fixture('message-details.html').read, @renderer.render_html(ALERTDATA, ALERTRULE_DETAILS)
+  end
+end

test/test_helper.rb

@@ -1,4 +1,8 @@
-$LOAD_PATH.unshift File.expand_path("../../lib", __FILE__)
-require "grafana_matrix"
+$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+require 'grafana_matrix'
 
-require "minitest/autorun"
+require 'minitest/autorun'
+
+def load_fixture(filename)
+  File.open(File.join('test', 'fixtures', filename))
+end