Prepare for CI

Author: ananace

.rubocop.yml

@@ -1,10 +1,11 @@
 ---
 AllCops:
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.5
   Exclude:
     - '*.spec'
     - 'Rakefile'
     - 'vendor/**/*'
+  NewCops: enable
 
 # Don't enforce documentation
 Style/Documentation:
@@ -16,9 +17,6 @@ Style/FrozenStringLiteralComment:
 Style/MultilineBlockChain:
   Enabled: false
 
-Layout/IndentHeredoc:
-  Enabled: false
-
 Metrics/PerceivedComplexity:
   Enabled: false
 
@@ -31,17 +29,11 @@ Style/RescueModifier:
 Metrics/MethodLength:
   Max: 40
 
-Metrics/LineLength:
-  Max: 190
-
 Metrics/AbcSize:
   Enabled: false
 
-Performance/FixedSize:
-  Exclude:
-    - 'test/**/*'
-
 Metrics/BlockLength:
+  Max: 40
   Exclude:
     - 'test/**/*'
 
@@ -50,8 +42,8 @@ Metrics/ClassLength:
   Exclude:
     - 'test/**/*'
 
-Lint/AmbiguousBlockAssociation:
-  Enabled: false
+Layout/LineLength:
+  Max: 190
 
 Style/ClassAndModuleChildren:
   Exclude:

.travis.yml

@@ -0,0 +1,17 @@
+---
+sudo: false
+language: ruby
+rvm:
+  - 2.5
+  - 2.6
+  - 2.7
+  - 3.0
+
+cache:
+  bundler: true
+before_install:
+  - gem install bundler rubocop
+  - gem update --system
+script:
+  - rubocop lib/
+  - bundle exec rake test

Gemfile

@@ -4,3 +4,6 @@ git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in grafana_matrix.gemspec
 gemspec
+
+gem 'json'
+gem 'rubocop'

config.ru

@@ -1,7 +1,7 @@
 require 'grafana_matrix'
 
 config = GrafanaMatrix::Config.new 'config.yml'
-warn 'Specifying port/bind in config '
+warn 'Specifying port/bind in config' if config.port? || config.bind?
 
 Signal.trap('HUP') do
   warn "[#{Time.now}] SIGHUP received, reloading configuration"

grafana_matrix.gemspec

@@ -21,4 +21,5 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'minitest'
+  spec.add_development_dependency 'rake'
 end

lib/grafana_matrix/config.rb

@@ -3,7 +3,6 @@
 
 module GrafanaMatrix
   class Config
-    # rubocop:disable Metrics/BlockLength
     Rule = Struct.new(:config, :data) do
       def name
         data.fetch(:name)
@@ -64,7 +63,6 @@ def client
         @client ||= config.client(matrix)
       end
     end
-    # rubocop:enable Metrics/BlockLength
 
     def initialize(config = {})
       if config.is_a? String
@@ -115,7 +113,7 @@ def client(client_name = nil)
         client_data = client_data.dup
 
         # Symbolize keys
-        client_data.keys.each do |key|
+        client_data.each_key do |key|
           client_data[(key.to_sym rescue key)] = client_data.delete key
         end
 
@@ -131,7 +129,7 @@ def rules(rule_name)
         rule_data = rule_data.dup
 
         # Symbolize keys
-        rule_data.keys.each do |key|
+        rule_data.each_key do |key|
           rule_data[(key.to_sym rescue key)] = rule_data.delete key
         end
 

lib/grafana_matrix/server.rb

@@ -39,7 +39,7 @@ def authorized(user, pass)
       halt 404, 'No such rule configured' if rules.empty?
 
       data = request.body.read
-      halt 400, 'No notification body provided' if data.empty? 
+      halt 400, 'No notification body provided' if data.empty?
 
       data = JSON.parse(data) rescue nil
       halt 400, 'Unable to parse notification body' unless data
@@ -83,7 +83,7 @@ def authorized(user, pass)
                                   format: 'org.matrix.custom.html')
       end
 
-      ''
+      { result: :success }.to_json
     end
   end
 end

test/grafana_matrix_test.rb

@@ -4,8 +4,4 @@ class GrafanaMatrixTest < Minitest::Test
   def test_that_it_has_a_version_number
     refute_nil ::GrafanaMatrix::VERSION
   end
-
-  def test_it_does_something_useful
-    assert false
-  end
 end