Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for ad3552r_hs #629

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

spectrum70
Copy link
Contributor

Add ad3552r_hs (high speed) driver, test script, example code, rst file and emu xml.

This driver is intended to be used with AXI driver version (named as high-speed, with hs suffix in Linux).

Tested:

  • pytest
  • invoke precommit
  • pre-commit run --all-files
  • executed sample on target

All tests passed.

Description

Currently, there is ad3552r.py to match the simple-spi Linux driver. Adding -hs version for the AXI based ad3552r-hs driver just mainlined.

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • pytest
  • invoke precommit
  • pre-commit run --all-files
  • executed sample on target

Test Configuration:

  • Hardware: zynq-zed + EVAL_AD3552RFMC1Z
  • OS: mainline linux

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@spectrum70
Copy link
Contributor Author

@tfcollins

hi, not sure if any reviewer has been automaticallly triggered, could you please have a look to this ? Thanks.

Copy link
Collaborator

@tfcollins tfcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the lint issue and we can merge

@spectrum70
Copy link
Contributor Author

@tfcollins thanks, done. Don't see lint check running but should be all ok.

Add ad3552r_hs (high speed) driver, test script, example code,
rst file and emu xml.

This driver is intended to be used with AXI driver version
(named as high-speed, with hs suffix in Linux).

Tested:
- pytest
- invoke precommit
- pre-commit run --all-files
- executed sample on target

All tests passed.

Signed-off-by: Angelo Dureghello <[email protected]>
@tfcollins tfcollins merged commit d03f189 into analogdevicesinc:main Jan 31, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants