-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for adrv9371 and adrv9009 #584
Conversation
2a24252
to
9fb5c5a
Compare
@tfcollins PR is ready for review. I updated the emulated test workflow - to run the test without the optional dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Primarily just questions on the DEC8/INT8 updates
Signed-off-by: Trecia Agoylo <[email protected]>
Signed-off-by: Trecia Agoylo <[email protected]>
Signed-off-by: Trecia Agoylo <[email protected]>
Signed-off-by: Trecia Agoylo <[email protected]>
Signed-off-by: Trecia Agoylo <[email protected]>
Signed-off-by: Trecia Agoylo <[email protected]>
Signed-off-by: Trecia Agoylo <[email protected]>
Signed-off-by: Trecia Agoylo <[email protected]>
Signed-off-by: Trecia Agoylo <[email protected]>
Signed-off-by: Trecia Agoylo <[email protected]>
Signed-off-by: Trecia Agoylo <[email protected]>
Signed-off-by: Trecia Agoylo <[email protected]>
Signed-off-by: Trecia Agoylo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really necessary aea0aca ? Did something break these?
Yes, all of the tests were skipped before and were not run, and when I tried to run in emulation mode they are failing as it is trying to set some configs so I picked valid tests for emu. |
Description
This PR includes fixes for adrv9371 and adrv9009 as well as their tests.
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: