Dev/adis16475 tests #517
Merged
Dev/adis16475 tests #517
+236
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbolboac
force-pushed
the
dev/adis16475_tests
branch
3 times, most recently
from
3fc35c5 to
762bfa4
Compare
|
Generated documentation for this PR is available at Link |
|
Hello @tfcollins , |
tfcollins
requested changes
Feb 2, 2024
test/test_adis16475_p.py
Outdated
| adis16475.sample_rate = 2000.0 / (i + 1) | ||
| assert adis16475.sample_rate >= (2000.0 / (i + 1) - 1) | ||
| assert adis16475.sample_rate <= (2000.0 / (i + 1) + 1) | ||
| adis16475.sample_rate = 2000.0 |
There was a problem hiding this comment.
Is this needed for downstream tests? If so either use a fixture to create a test dependency
There was a problem hiding this comment.
I forgot I was already testing the sample rate in test_adis16475_attr, I will remove this.
| if self._ctrl is not None: | ||
| print("Fond device = " + i + ". Will use this device instead.") | ||
| break | ||
|
|
There was a problem hiding this comment.
Need a check to make sure a device is found
There was a problem hiding this comment.
I added an exception in case no device is found
Signed-off-by: Ramona Gradinariu <[email protected]>
Signed-off-by: Ramona Gradinariu <[email protected]>
rbolboac
force-pushed
the
dev/adis16475_tests
branch
from
762bfa4 to
5a23b85
Compare
|
Hello @tfcollins , Any feedback after new changes? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new tests for adis16475 driver and change the xml to the latest version of the drivers to include also the delta channels.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration: A
Test Configuration: B
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: