Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ad5754r update driver and examples #501

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Ad5754r update driver and examples #501

merged 2 commits into from
Nov 29, 2023

Conversation

ribdp
Copy link
Contributor

@ribdp ribdp commented Nov 28, 2023

Description

  1. Update driver to support additional attributes defined in the firmware
  2. Remove typos from the example script
  3. Update example script to demonstrate use of the dac attributes

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested driver and example script with SDP-K1 and EVAL-AD5754REBZ

Test Configuration:

  • Hardware: SDP-K1, EVAL-AD5754REBZ
  • OS: ad5754r iio firmware application running on SDP-K1; Python 3.7 on Windows 10

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Fix typos in variable name

Signed-off-by: RibhuDP <[email protected]>
1. Add additional dac device and channel attributes
2. Update example script to demonstrate usage of attributes

Signed-off-by: RibhuDP <[email protected]>
@ribdp ribdp marked this pull request as ready for review November 28, 2023 14:36
@ribdp
Copy link
Contributor Author

ribdp commented Nov 28, 2023

Hi @tfcollins - this PR is ready for review

@tfcollins tfcollins merged commit 0e7c0de into analogdevicesinc:main Nov 29, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants