Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for CN0565. #484

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Add Support for CN0565. #484

merged 4 commits into from
Jan 15, 2024

Conversation

mc-so
Copy link
Contributor

@mc-so mc-so commented Oct 9, 2023 •
edited
Loading

Description

Adding pyadi-iio support for CN0565 - Electrical Impedance Tomography Measurement System including basic examples.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

The example scripts were tested under Windows OS using EVAL-ADICUP3029 which is an Arduino compatible form factor development board attached to the EVAL-CN0565-ARDZ and its test board.

Test Configuration:

  • Hardware: EVAL-CN0565-ARDZ + EVAL-ADICUP3029
  • OS: Windows 10

Documentation

Product Page: https://www.analog.com/en/design-center/reference-designs/circuits-from-the-lab/cn0565.html
User Guide: https://wiki.analog.com/resources/eval/user-guides/circuits-from-the-lab/cn0565

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mc-so mc-so marked this pull request as draft October 9, 2023 09:40
tfcollins
tfcollins reviewed Oct 10, 2023
View reviewed changes
.vscode/launch.json Outdated Show resolved Hide resolved
tfcollins
tfcollins reviewed Oct 10, 2023
View reviewed changes
adi/cn0565.py Outdated Show resolved Hide resolved
tfcollins
tfcollins reviewed Oct 10, 2023
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
tfcollins
tfcollins reviewed Oct 10, 2023
View reviewed changes
test/pyvenv.cfg Outdated Show resolved Hide resolved
tfcollins
tfcollins reviewed Oct 10, 2023
View reviewed changes
examples/cn0565/query.py Outdated Show resolved Hide resolved
tfcollins
tfcollins requested changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@tfcollins tfcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to run the linters

@mc-so mc-so force-pushed the dev/cn0565 branch 4 times, most recently from 8e955fa to b54d876 Compare October 27, 2023 12:31
kister-jimenez
kister-jimenez reviewed Dec 15, 2023
View reviewed changes
examples/cn0565/cn0565_prod_tst.py Outdated Show resolved Hide resolved
examples/cn0565/README.md Show resolved Hide resolved
@kister-jimenez kister-jimenez changed the title Dev/cn0565 Add Support for CN0565. Dec 18, 2023
@kister-jimenez kister-jimenez added the enhancement New feature or request label Dec 18, 2023
@mc-so mc-so marked this pull request as ready for review December 18, 2023 06:50
@kister-jimenez
Copy link
Collaborator

I had a call with Michelle to discuss some changes (i.e rebasing to main, squashing commits, lints, design pattern, etc.) and she fixed it in the latest push.

I'm ok with this.

@kister-jimenez
Copy link
Collaborator

kister-jimenez commented Dec 19, 2023 •
edited
Loading

I had a call with Michelle to discuss some changes (i.e rebasing to main, squashing commits, lints, design pattern, etc.) and she fixed it in the latest push.

I'm ok with this.

I just noticed a lot of files. Please rebase commits to the correct main and PR to main branch.

@mc-so mc-so changed the base branch from master to main December 19, 2023 03:45
@tfcollins
Copy link
Collaborator

Can you reorder your commits to create a clean rebase?

@tfcollins
Copy link
Collaborator

Emulation file is missing cn0565.xml. Please run pre-commit checks as well

@mc-so mc-so force-pushed the dev/cn0565 branch 2 times, most recently from aca9306 to 9b90471 Compare January 9, 2024 04:22
mc-so added 4 commits January 12, 2024 12:18
@mc-so
Added CN0565 Support
a1af997 
Signed-off-by: Michelle Claire So <[email protected]>
@mc-so
Add documentation for CN0565
2574841 
Signed-off-by: Michelle Claire So <[email protected]>
@mc-so
Added cn0565 pyadi-iio examples
26a9621 
Signed off by: Michelle Claire So <[email protected]>
@mc-so
Added test for CN0565
39b52d8 
Signed-off-by: mc-so <[email protected]>
@tfcollins tfcollins merged commit 69b2d7a into analogdevicesinc:main Jan 15, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kister-jimenez kister-jimenez kister-jimenez left review comments

@tfcollins tfcollins tfcollins approved these changes

@thorenscientific thorenscientific Awaiting requested review from thorenscientific

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mc-so @kister-jimenez @tfcollins