lookup table based crc-8 implementation #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scuciurean
reviewed
Feb 25, 2020
| * @return crc - Computed CRC-8 value. | ||
| *******************************************************************************/ | ||
| uint8_t crc8(const uint8_t * table, const uint8_t *pdata, size_t nbytes, | ||
| uint8_t crc) |
There was a problem hiding this comment.
Since the description says the last parameter (crc) represents the initial value, wouldn't it be more clear to rename it this way?
There was a problem hiding this comment.
i added more explanation to the function documentation. basically, the value you put there is typically a crc so i think it makes sense the stay that way
dbogdan
reviewed
Feb 25, 2020
util/crc8.c
Outdated
| * @brief Source file of CRC-8 computation. | ||
| * @author Darius Berghe ([email protected]) | ||
| ******************************************************************************** | ||
| * Copyright 2012(c) Analog Devices, Inc. |
amiclaus
requested changes
Feb 27, 2020
util/crc8.c
Outdated
|
|
||
| return crc; | ||
| } | ||
|
|
This is code compatible with linux crc8.h although the implementation is somewhat different. This implementation is supposed to replace all crc-8 implementations in no-OS drivers which are all duplicates of each other. By comparing the performance of this new implementation with the old one on an x86 machine and on large sample sizes, it seems the new implementation is faster by a factor of 13. Signed-off-by: Darius Berghe <[email protected]>
|
Following previous comments I:
|
amiclaus
approved these changes
Mar 2, 2020
dbogdan
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is code compatible with linux crc8.h although the implementation is
somewhat different.
This implementation is supposed to replace all crc-8 implementations in no-OS
drivers which are all duplicates of each other.
By comparing the performance of this new implementation with the old one on
an x86 machine and on large sample sizes, it seems the new implementation is
faster by a factor of 13.
I suggest to review but not merge this until we have a working projects/ad7768-1 to test it on. I did test it on x86 and gives the same result as our existing algorithm.