Skip to content

Conversation

@artursartamonovsadi
Copy link

PR Description

This PR remove device-tree configs that causes issues with NFSBOOT for SC594 EZLITE and EZKIT:
SC594 EZKIT : missed to remove emac0txconfig: tx-config in #2966
SC594 EZLITE : removed snps,mtl-rx-config and snps,mtl-tx-config from emac0 config
tested network performance with iperf3 no issues observed

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have compiled my changes, including the documentation
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly
  • I have provided links for the relevant upstream lore

@artursartamonovsadi artursartamonovsadi force-pushed the adsp-main-6.12-sc594-ethernet-dma branch from 9df8120 to 539bb6a Compare October 29, 2025 15:46
@artursartamonovsadi artursartamonovsadi changed the title devicetree: arm: SC594-EZLITE/EZKIT remove tx/rx queue configs ARM: dts: adi: SC594-EZLITE/EZKIT remove tx/rx queue configs Oct 29, 2025
Copy link
Collaborator

@nunojsa nunojsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would only complain that:

"This PR remove device-tree configs that causes issues with NFSBOOT for SC594 EZLITE and EZKIT:
SC594 EZKIT : missed to remove emac0txconfig: tx-config in #2966
SC594 EZLITE : removed snps,mtl-rx-config and snps,mtl-tx-config from emac0 config
tested network performance with iperf3 no issues observed"

Should be in the commit message but I guess the patch will be anyways (eventually) squashed...

@pamolloy
Copy link
Collaborator

LGTM, I would only complain that:

"This PR remove device-tree configs that causes issues with NFSBOOT for SC594 EZLITE and EZKIT: SC594 EZKIT : missed to remove emac0txconfig: tx-config in #2966 SC594 EZLITE : removed snps,mtl-rx-config and snps,mtl-tx-config from emac0 config tested network performance with iperf3 no issues observed"

Should be in the commit message but I guess the patch will be anyways (eventually) squashed...

Also for the future, unless we start using --fixup commits it is also helpful to add a Fixes: tag so we know which commit to squash with.

@nunojsa
Copy link
Collaborator

nunojsa commented Oct 30, 2025

Also for the future, unless we start using --fixup commits it is also helpful to add a Fixes: tag so we know which commit to squash with.

Definitely. FWIW, if the point will be to squash, +1 for using --fixup.

@artursartamonovsadi artursartamonovsadi merged commit 7da0cef into adsp-main-6.12 Oct 31, 2025
1 check passed
@artursartamonovsadi artursartamonovsadi deleted the adsp-main-6.12-sc594-ethernet-dma branch October 31, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants